Skip to content

fix(web): keep item page hero text readable over bright artwork - #4944

Open
Quick104 wants to merge 3 commits into
mainfrom
fix/web-detail-hero-scrim-contrast
Open

Quick104 wants to merge 3 commits into
mainfrom
fix/web-detail-hero-scrim-contrast

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Closes #4569
Related issue: N/A
Validation tasks: none

Other clients: N/A (web-only layout fix; Apple, Android, and Roku draw their own detail hero)

On the web item page, the text in the hero's left column becomes unreadable wherever the backdrop is bright behind it. That covers the overview, tagline, eyebrow, metadata, crew line, and episode breadcrumb. It happens on movie, series, season, and episode pages, at every width, and is worst on phones and tablets where the text spans the hero.

Measured on main against the art behind each glyph: 37 of 39 titles in a test library have overview text below 4.5:1 at 1440×900, down to 1.0:1. At phone width the overview, tagline, and episode title reach 1.0:1. On "10 Things I Hate About You" the overview's worst 1% of glyphs measured 1.34:1, over white shirts.

This change draws a shade behind the hero's text block, so every hero text colour keeps 4.5:1 over any artwork and the rest of the backdrop keeps its brightness.

Approach

The hero's existing fades are positioned as percentages of the hero (the side fade ends at 52% of the width, the bottom fade weakens above 34% of the height). The text block doesn't follow those percentages: it ends around 71% of the width on a desktop, spans the full width below lg, and grows with the overview. No tuning of those stops holds across widths and page types without darkening the whole hero.

So the shade belongs to the text block instead (.detail-hero-copy::before): 85% of --background, easing out above the text and past its end edge, mirrored in RTL. It also runs 100rem toward the hero's start edge, which reaches that edge in windows up to 3840px wide while keeping the copy's compositor layer small. 85% is the least that keeps the dimmest hero text colours (--muted-foreground, and text-foreground/60 for genres) at 4.5:1 over pure white, so it holds without the existing fades, which stay as they were. A hero without backdrop artwork draws no shade.

Three changes make the shade land in the right place:

  • On series, season, and episode pages at desktop width, the text block filled the hero's height with its text pushed to the bottom. It now fits its content, so the shade starts at the text. Every other layout box stays where it was, with short and very long overviews at three desktop sizes.
  • The poster sits above the shade.
  • The hero clips its overflow instead of hiding it, so the shade can't make the hero scrollable by focus or find-in-page.

The "Directed by", "Written by", and "By" labels and the current breadcrumb step were at 3.4:1 even on a plain background. The labels now use the line's muted colour and the crew names the foreground colour, so names still stand out from their labels, in high contrast too. Linked names underline on hover. The current breadcrumb step uses the foreground colour, which also sets it apart from the linked steps. web/docs/design-system.md records the rule for text over hero artwork.

A text halo alone, which the issue suggested, doesn't fix it: the gaps between strokes stay bright, and the text still read at about 1.5:1 against nearby backdrop pixels.

Validation

  • Live, on a dev sandbox built from main and then from this branch: glyph-pixel WCAG contrast of every hero text element (text drawn as a mask, then transparent, with the element's colour and opacity composited over each backdrop pixel), plus a stricter check of each glyph against the brightest backdrop pixel within 3 CSS px.
    • Main: overview below 4.5:1 on 37 of 39 titles at 1440×900, worst 1.0:1; 1.0:1 at the iPhone and iPad presets.
    • This branch: every hero text element at or above 4.5:1 on all 39 titles at 1440×900 and on 4 titles at the iPhone and iPad presets (644, 69, and 70 elements). Weakest overview 5.63:1. The · separators are decorative and stay as they were.
  • Before and after captures at desktop, tablet, and phone widths for a movie, a series, and an episode, plus high contrast, RTL, keyboard focus, a title with no backdrop, and windows 1920 to 3840 wide. No console errors on the branch.
  • On a full-height episode page (rail removed) with a long overview and an oversized action bar, main and this PR give the same action bar and overview heights at three short window sizes.
  • Box set, manga, and request pages also render this hero; the test library has none of them, so they weren't checked live.
  • Web lint, format, typecheck, build, bundle budget, and the web test suite pass. No test added: this is a CSS change, verified by the measurements above.

Evidence: https://evidence.siloserver.org/r/silo-server/issue-4569/

Risks

  • The backdrop is darker behind the text. On phone and tablet series and episode pages, where the text covers most of the hero, most of the artwork is shaded. That is the cost of 4.5:1 for the muted text colours; a lighter shade would need brighter hero text tokens.
  • On very pale artwork the shade's top corner and end edge stay visible, and can cross a face in the art.
  • The shade checks that a backdrop element exists, not that its image loaded. A backdrop URL that fails with no thumbhash still draws the shade over the ambient glow.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Rounds: 1 finished, round 2 running on 87e4e75

Member Round 1 (a86fb5f) Round 2 (87e4e75)
Sol (gpt-6.2-sol, xhigh) 8/10 running
Opus (claude-opus-5-5, high) 8/10 running
Gemini (gemini-4-neon, xhigh) unavailable (quota) running (retry)

Visual review: 2 rounds, on captures from the same hero CSS as a86fb5f

Member Round 1 Round 2
Sol better, 7/10 better, 7.5/10
Opus better, 7/10 better, 7.5/10
Gemini better, 6.5/10 unavailable (quota)

Fixed: eased, longer fades; no shade without a backdrop; brighter current breadcrumb step; crew names above their labels (Opus O1); a shade bounded to 100rem before the text (Sol S2). Answered: the action bar's height cap still resolves on full-height episode pages (Kody); a near-black branding accent improves from 1.88:1 to 4.13:1 here, and the rest is the accent-text case left open on #4780 (Sol S1); phone and tablet shading is what 4.5:1 needs where the text spans the hero; the remaining corner on pale art is listed under Risks.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code, Codex CLI, Antigravity, Playwright (headless Chromium)
  • Model(s): claude-opus-5-5 (implementation), gpt-6.2-sol, gemini-4-neon, claude-sonnet-5-5 (reviews)
  • Involvement: Fully AI-generated, human verified
  • Adversarial review: before implementing, Sol, Opus, and Gemini reviewed the plan. Their findings led to fitting the text block on series and episode pages, an 85% shade instead of 84% so the genres pass, overflow-clip, and a simpler mask. A multi-agent code review at high effort replaced a viewport-sized inset with a fixed one and removed leftover wrappers. See Council review.

🤖 Generated with Claude Code

The item page hero's fades sit at fixed percentages of its size, so the
overview, tagline and the rest of the text column fell to about 1:1 over
pale artwork, worst at phone and tablet widths where the text spans the
hero. Draw a shade behind the hero's text block instead: 85% of the page
background, easing out above the text and past its end edge, so every
hero text colour keeps 4.5:1 over pure white and the rest of the artwork
keeps its brightness.

On series, season and episode pages at desktop width the text block now
fits its content, so the shade starts at the text. The poster sits above
the shade, the hero clips instead of hiding its overflow, and a hero with
no artwork draws no shade. The "Directed by" and "Written by" labels and
the current breadcrumb step are no longer faded below 4.5:1.

Closes #4569

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a1f8220-a3a1-4292-9afc-9aab514294be
Commits

Reviewing files that changed from the base of the PR and between 6525a3f and 87e4e75.

Files selected for processing: 6

  • web/docs/design-system.md
  • web/src/app.css
  • web/src/pages/ItemDetail/DetailHero.tsx
  • web/src/pages/ItemDetail/components/DetailBreadcrumb.tsx
  • web/src/pages/ItemDetail/components/HeroCrewLine.tsx
  • web/src/pages/ItemDetail/detailLayout.css
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T07:40:19.890694Z 87e4e75 New commits
🔒 Security Review ✅ Completed 2026-11-21T07:41:28.776931Z 87e4e75 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (claude-opus-5-5, reviewed a86fb5f)

One finding, on the crew line. I found nothing to report on the shade itself. Its RTL mirroring, the poster stacking, the gate on .hero-backdrop-artwork, the bounded-copy fit, browser support (the web app already depends on :has() and color-mix()), and reduced motion all check out against the code. On phones the TV pages set overflow: visible on the hero, so the shade is clipped there by the existing contain: paint on .item-detail-hero, not by overflow-clip. That works, but the code comment credits the wrong rule.

AI disclosure: this review was written by Claude Opus 5.5 (claude-opus-5-5).

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed a86fb5f)

Score: 8/10. Posted by the run that launched this review, because the review task couldn't submit it pinned to the reviewed commit. The findings are Sol's, checked against the source before posting.

S1 (medium): a near-black branding accent can leave accent-coloured hero text below 4.5:1. With a #050505 accent, a white backdrop, and a long movie overview, the audience score measured 4.13:1 at 1100×760 in Chromium, Firefox, and WebKit, up from 1.88:1 on the base. The accent text colour (web/src/lib/accentColor.ts) is computed against the lightest page surface, which is darker than the 85% shade over white art. Suggested repair: derive hero accent text against the brightest background it can render on, or account for branded text when setting the shade's strength.

🤖 Claude Code (claude-opus-5-5), posting for Sol (gpt-6.2-sol)

Comment thread web/src/app.css Resolved
Quick104 and others added 2 commits November 21, 2026 01:54
…abels

The shade behind the hero's text reached 200rem toward the start edge, so
the text block's compositor layer grew to about 4,000px and resizes
rasterized far more than the hero shows. Start it 100rem before the text,
which still reaches the hero's start edge in windows up to 3840px wide,
and fade its start side so wider windows don't show an edge.

Unfading the "Directed by" and "Written by" labels left them the same
colour as the crew names, and brighter than the names in high contrast.
Names now use the foreground colour, and linked names underline on hover.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (claude-opus-5-5, reviewed 87e4e75)

One nit; no correctness findings.

Checked and found no problem:

  • Phone and tablet episode, series and season pages set the hero to overflow: visible (.episode-detail-viewport .item-detail-hero outranks overflow-clip), but .item-detail-hero { contain: layout paint style } still clips the shade to the hero, so it cannot cover the More Episodes or Episodes heading below.
  • The poster (z-[1]) and the back button (z-20) paint above the shade. No caller passes aside, so no hero text sits outside the copy.
  • On series and season pages at desktop width the hero is content-sized (minmax(max-content, 1fr)), so the copy never has to shrink, and the action bar's 65%/45% cap not resolving in the row flex layout does no harm.
  • Over pure white, 85% of --background gives --muted-foreground about 4.8:1 and text-foreground/60 genres about 4.6:1. High contrast only lightens text, so it keeps those ratios.
  • Crew names and the current breadcrumb only change class, so links and the routes they open (#1144 C1) are unchanged. The translated overview label (#1215) is outside this diff.
  • Round 1 O1 is resolved: names are now text-foreground and labels inherit the muted colour.

AI disclosure: written by claude-opus-5-5 (Claude Code) as an automated adversarial reviewer.

Comment thread web/src/app.css
color-mix(in srgb, var(--background) 85%, transparent) 10rem
);
--detail-hero-copy-side-fades: linear-gradient(
calc(90deg * var(--dir-sign)),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the mask is symmetric. It has the same 8rem fade, with the same stops, at both ends, so flipping its angle in RTL produces the same mask. calc(90deg * var(--dir-sign)) changes nothing here, and the PR description's "mirrored by --dir-sign" makes it look like something depends on reading direction. RTL support comes from the inset-inline offsets. A plain 90deg (or to right) gives the same result in both directions. Use --dir-sign only if the two ends ever get different fades.

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed 87e4e75)

Score: 7/10. Posted by the run that launched this review, because the review task couldn't submit it pinned to the reviewed commit. The findings are Sol's, checked against the source before posting.

S3 (medium, web/src/pages/ItemDetail/DetailHero.tsx title art <img>): the new shade hides dark title logos. Title art is on by default, and a series page at 390×844 hides its poster, so the logo is the only visible title. With a pale backdrop and dark lettering, median logo contrast fell from 10.02:1 to 1.20:1 in Chromium and from 9.91:1 to 1.18:1 in Firefox. Logos are exempt from WCAG 1.4.3, but viewers are still left without a legible title. Suggested repair: give the logo an adaptive backing, or show the text title when the logo has poor contrast.

Earlier findings: S1 (near-black branding accent) still open, tracked with #4780's accent-text case. S2 (shade size) resolved in code; raster cost on low-end hardware still unmeasured. O1 (crew names vs labels) resolved, and the short full-height episode layout keeps main's action bar height.

🤖 Claude Code (claude-opus-5-5), posting for Sol (gpt-6.2-sol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Detail page overview is hard to read on bright backdrops

1 participant