Repository navigation
Conversation
The item page hero's fades sit at fixed percentages of its size, so the overview, tagline and the rest of the text column fell to about 1:1 over pale artwork, worst at phone and tablet widths where the text spans the hero. Draw a shade behind the hero's text block instead: 85% of the page background, easing out above the text and past its end edge, so every hero text colour keeps 4.5:1 over pure white and the rest of the artwork keeps its brightness. On series, season and episode pages at desktop width the text block now fits its content, so the shade starts at the text. The poster sits above the shade, the hero clips instead of hiding its overflow, and a hero with no artwork draws no shade. The "Directed by" and "Written by" labels and the current breadcrumb step are no longer faded below 4.5:1. Closes #4569 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 3 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (claude-opus-5-5, reviewed a86fb5f)
One finding, on the crew line. I found nothing to report on the shade itself. Its RTL mirroring, the poster stacking, the gate on .hero-backdrop-artwork, the bounded-copy fit, browser support (the web app already depends on :has() and color-mix()), and reduced motion all check out against the code. On phones the TV pages set overflow: visible on the hero, so the shade is clipped there by the existing contain: paint on .item-detail-hero, not by overflow-clip. That works, but the code comment credits the wrong rule.
AI disclosure: this review was written by Claude Opus 5.5 (claude-opus-5-5).
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (gpt-6.2-sol, reviewed a86fb5f)
Score: 8/10. Posted by the run that launched this review, because the review task couldn't submit it pinned to the reviewed commit. The findings are Sol's, checked against the source before posting.
S1 (medium): a near-black branding accent can leave accent-coloured hero text below 4.5:1. With a #050505 accent, a white backdrop, and a long movie overview, the audience score measured 4.13:1 at 1100×760 in Chromium, Firefox, and WebKit, up from 1.88:1 on the base. The accent text colour (web/src/lib/accentColor.ts) is computed against the lightest page surface, which is darker than the 85% shade over white art. Suggested repair: derive hero accent text against the brightest background it can render on, or account for branded text when setting the shade's strength.
🤖 Claude Code (claude-opus-5-5), posting for Sol (gpt-6.2-sol)
…abels The shade behind the hero's text reached 200rem toward the start edge, so the text block's compositor layer grew to about 4,000px and resizes rasterized far more than the hero shows. Start it 100rem before the text, which still reaches the hero's start edge in windows up to 3840px wide, and fade its start side so wider windows don't show an edge. Unfading the "Directed by" and "Written by" labels left them the same colour as the crew names, and brighter than the names in high contrast. Names now use the foreground colour, and linked names underline on hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (claude-opus-5-5, reviewed 87e4e75)
One nit; no correctness findings.
Checked and found no problem:
- Phone and tablet episode, series and season pages set the hero to
overflow: visible(.episode-detail-viewport .item-detail-herooutranksoverflow-clip), but.item-detail-hero { contain: layout paint style }still clips the shade to the hero, so it cannot cover the More Episodes or Episodes heading below. - The poster (
z-[1]) and the back button (z-20) paint above the shade. No caller passesaside, so no hero text sits outside the copy. - On series and season pages at desktop width the hero is content-sized (
minmax(max-content, 1fr)), so the copy never has to shrink, and the action bar's 65%/45% cap not resolving in the row flex layout does no harm. - Over pure white, 85% of
--backgroundgives--muted-foregroundabout 4.8:1 andtext-foreground/60genres about 4.6:1. High contrast only lightens text, so it keeps those ratios. - Crew names and the current breadcrumb only change class, so links and the routes they open (#1144 C1) are unchanged. The translated overview label (#1215) is outside this diff.
- Round 1 O1 is resolved: names are now
text-foregroundand labels inherit the muted colour.
AI disclosure: written by claude-opus-5-5 (Claude Code) as an automated adversarial reviewer.
| color-mix(in srgb, var(--background) 85%, transparent) 10rem | ||
| ); | ||
| --detail-hero-copy-side-fades: linear-gradient( | ||
| calc(90deg * var(--dir-sign)), |
There was a problem hiding this comment.
Nit: the mask is symmetric. It has the same 8rem fade, with the same stops, at both ends, so flipping its angle in RTL produces the same mask. calc(90deg * var(--dir-sign)) changes nothing here, and the PR description's "mirrored by --dir-sign" makes it look like something depends on reading direction. RTL support comes from the inset-inline offsets. A plain 90deg (or to right) gives the same result in both directions. Use --dir-sign only if the two ends ever get different fades.
Quick104
left a comment
There was a problem hiding this comment.
Adversarial review (gpt-6.2-sol, reviewed 87e4e75)
Score: 7/10. Posted by the run that launched this review, because the review task couldn't submit it pinned to the reviewed commit. The findings are Sol's, checked against the source before posting.
S3 (medium, web/src/pages/ItemDetail/DetailHero.tsx title art <img>): the new shade hides dark title logos. Title art is on by default, and a series page at 390×844 hides its poster, so the logo is the only visible title. With a pale backdrop and dark lettering, median logo contrast fell from 10.02:1 to 1.20:1 in Chromium and from 9.91:1 to 1.18:1 in Firefox. Logos are exempt from WCAG 1.4.3, but viewers are still left without a legible title. Suggested repair: give the logo an adaptive backing, or show the text title when the logo has poor contrast.
Earlier findings: S1 (near-black branding accent) still open, tracked with #4780's accent-text case. S2 (shade size) resolved in code; raster cost on low-end hardware still unmeasured. O1 (crew names vs labels) resolved, and the short full-height episode layout keeps main's action bar height.
🤖 Claude Code (claude-opus-5-5), posting for Sol (gpt-6.2-sol)
Problem
Closes #4569
Related issue: N/A
Validation tasks: none
Other clients: N/A (web-only layout fix; Apple, Android, and Roku draw their own detail hero)
On the web item page, the text in the hero's left column becomes unreadable wherever the backdrop is bright behind it. That covers the overview, tagline, eyebrow, metadata, crew line, and episode breadcrumb. It happens on movie, series, season, and episode pages, at every width, and is worst on phones and tablets where the text spans the hero.
Measured on main against the art behind each glyph: 37 of 39 titles in a test library have overview text below 4.5:1 at 1440×900, down to 1.0:1. At phone width the overview, tagline, and episode title reach 1.0:1. On "10 Things I Hate About You" the overview's worst 1% of glyphs measured 1.34:1, over white shirts.
This change draws a shade behind the hero's text block, so every hero text colour keeps 4.5:1 over any artwork and the rest of the backdrop keeps its brightness.
Approach
The hero's existing fades are positioned as percentages of the hero (the side fade ends at 52% of the width, the bottom fade weakens above 34% of the height). The text block doesn't follow those percentages: it ends around 71% of the width on a desktop, spans the full width below
lg, and grows with the overview. No tuning of those stops holds across widths and page types without darkening the whole hero.So the shade belongs to the text block instead (
.detail-hero-copy::before): 85% of--background, easing out above the text and past its end edge, mirrored in RTL. It also runs 100rem toward the hero's start edge, which reaches that edge in windows up to 3840px wide while keeping the copy's compositor layer small. 85% is the least that keeps the dimmest hero text colours (--muted-foreground, andtext-foreground/60for genres) at 4.5:1 over pure white, so it holds without the existing fades, which stay as they were. A hero without backdrop artwork draws no shade.Three changes make the shade land in the right place:
The "Directed by", "Written by", and "By" labels and the current breadcrumb step were at 3.4:1 even on a plain background. The labels now use the line's muted colour and the crew names the foreground colour, so names still stand out from their labels, in high contrast too. Linked names underline on hover. The current breadcrumb step uses the foreground colour, which also sets it apart from the linked steps.
web/docs/design-system.mdrecords the rule for text over hero artwork.A text halo alone, which the issue suggested, doesn't fix it: the gaps between strokes stay bright, and the text still read at about 1.5:1 against nearby backdrop pixels.
Validation
·separators are decorative and stay as they were.Evidence: https://evidence.siloserver.org/r/silo-server/issue-4569/
Risks
Checklist
Council review
Rounds: 1 finished, round 2 running on 87e4e75
Visual review: 2 rounds, on captures from the same hero CSS as a86fb5f
Fixed: eased, longer fades; no shade without a backdrop; brighter current breadcrumb step; crew names above their labels (Opus O1); a shade bounded to 100rem before the text (Sol S2). Answered: the action bar's height cap still resolves on full-height episode pages (Kody); a near-black branding accent improves from 1.88:1 to 4.13:1 here, and the rest is the accent-text case left open on #4780 (Sol S1); phone and tablet shading is what 4.5:1 needs where the text spans the hero; the remaining corner on pale art is listed under Risks.
AI Disclosure
overflow-clip, and a simpler mask. A multi-agent code review at high effort replaced a viewport-sized inset with a fixed one and removed leftover wrappers. See Council review.🤖 Generated with Claude Code