Repository navigation
fix(web): make a failed connection check readable on the dark panel - #4965
Conversation
The result next to "Check connection" used red-600 and green-600 with no dark-theme shade. Silo's only theme is dark, and red-600 measured 3.85:1 on the settings page backdrop at 14 px, below WCAG AA's 4.5:1. Pair each tone with its 400 shade under `dark:`, as SettingFieldStatus does. Closes #4934 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 13 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Closes #4934
Related issue: N/A
Validation tasks: none
Other clients: N/A (web admin only; the native clients have no connection check)
When a "Check connection" on an admin settings page fails, its message is red text that is hard to read on Silo's dark settings panel. It measured 3.85:1 against the Storage page backdrop and 3.56:1 on the plugin settings panel at 14 px, below WCAG AA's 4.5:1. This change uses lighter shades of red and green on the dark theme, so the failure message reaches 6.37:1.
Approach
ConnectionCheckActioncoloured its result withtext-red-600andtext-green-600and had no dark-theme shade. Silo's only theme is dark, andweb/src/app.cssdefines thedark:variant from thedata-themeattribute on<html>, sodark:classes apply on every page. Each tone now pairs with its 400 shade underdark:, matchingSettingFieldStatusin the same settings pages. The component is shared, so the fix also covers plugin settings, Redis, Search, Storage, Recommendations, and the two setup-wizard steps. Thewrap-anywherefrom #4933 stays.Validation
make lint-changedare clean. The admin settings and admin component vitest suites pass, apart from three timeouts in files that don't render this component; those pass when run alone.Evidence: https://evidence.siloserver.org/r/silo-server/issue-4934/
Risks
None identified. Only the result text's colour changes.
Checklist
Council review
This ran as a follow-up of #4933, with one reviewer per round at high effort.
Background review: 1 round, reviewed d0f1f3a. The reviewer couldn't post its review (the GitHub connector rejected it), so its one finding is summarized here.
Visual review: 1 round, captures from d0f1f3a
Answered: Sol asked for captures of the component's other screens and narrow widths. They render the same span, so the plugin panel's contrast is computed in the evidence instead; wrapping at narrow widths was covered by #4933, and this change doesn't affect layout. Sol's background finding said that in high contrast mode, which lightens the surfaces,
red-400drops below 4.5:1 in the setup wizard, and suggested thetext-destructive-labeltoken. On the settings and wizard panel surface in high contrast mode,red-400computes to 4.94:1, so the finding doesn't hold on the surfaces this text sits on. The token would leave more margin (8.92:1 there) if a later change wants it.AI Disclosure
🤖 Generated with Claude Code