Skip to content

fix(web): make a failed connection check readable on the dark panel - #4965

Merged
Quick104 merged 1 commit into
mainfrom
fix/connection-check-failure-contrast
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/connection-check-failure-contrast

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Closes #4934
Related issue: N/A
Validation tasks: none

Other clients: N/A (web admin only; the native clients have no connection check)

When a "Check connection" on an admin settings page fails, its message is red text that is hard to read on Silo's dark settings panel. It measured 3.85:1 against the Storage page backdrop and 3.56:1 on the plugin settings panel at 14 px, below WCAG AA's 4.5:1. This change uses lighter shades of red and green on the dark theme, so the failure message reaches 6.37:1.

Approach

ConnectionCheckAction coloured its result with text-red-600 and text-green-600 and had no dark-theme shade. Silo's only theme is dark, and web/src/app.css defines the dark: variant from the data-theme attribute on <html>, so dark: classes apply on every page. Each tone now pairs with its 400 shade under dark:, matching SettingFieldStatus in the same settings pages. The component is shared, so the fix also covers plugin settings, Redis, Search, Storage, Recommendations, and the two setup-wizard steps. The wrap-anywhere from #4933 stays.

Validation

  • Reproduced on a Silo dev deployment built from main: Admin → Server → Storage, with the S3 endpoint pointed at a closed port, shows the failure at 3.85:1 (computed colour against the composited backdrop in Chromium). After the fix it is 6.37:1. The success message goes from 5.71:1 to 10.34:1.
  • The plugin settings panel's lighter backdrop computes to 5.88:1 for the new red and 9.55:1 for the new green.
  • The browser console showed no errors on any run.
  • Prettier, ESLint on the file, and make lint-changed are clean. The admin settings and admin component vitest suites pass, apart from three timeouts in files that don't render this component; those pass when run alone.

Evidence: https://evidence.siloserver.org/r/silo-server/issue-4934/

Risks

None identified. Only the result text's colour changes.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

This ran as a follow-up of #4933, with one reviewer per round at high effort.

Background review: 1 round, reviewed d0f1f3a. The reviewer couldn't post its review (the GitHub connector rejected it), so its one finding is summarized here.

Member Round 1
Sol (gpt-6.2-sol, high) 8/10

Visual review: 1 round, captures from d0f1f3a

Member Round 1
Sol better, 9/10

Answered: Sol asked for captures of the component's other screens and narrow widths. They render the same span, so the plugin panel's contrast is computed in the evidence instead; wrapping at narrow widths was covered by #4933, and this change doesn't affect layout. Sol's background finding said that in high contrast mode, which lightens the surfaces, red-400 drops below 4.5:1 in the setup wizard, and suggested the text-destructive-label token. On the settings and wizard panel surface in high contrast mode, red-400 computes to 4.94:1, so the finding doesn't hold on the surfaces this text sits on. The token would leave more margin (8.92:1 there) if a later change wants it.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code; Codex (visual and background review); Playwright Chromium (captures and contrast measurement)
  • Model(s): claude-opus-5-5 (implementation), gpt-6.2-sol (review)
  • Involvement: Fully AI-generated. The agent verified it on a Silo dev deployment; a person has not verified it yet.
  • Adversarial review: the agent read the one-line diff in full and did not run a multi-agent code review on it. The plan round was skipped because the fix is mechanical. See Council review for the visual and background reviews.

🤖 Generated with Claude Code

The result next to "Check connection" used red-600 and green-600 with no
dark-theme shade. Silo's only theme is dark, and red-600 measured 3.85:1
on the settings page backdrop at 14 px, below WCAG AA's 4.5:1. Pair each
tone with its 400 shade under `dark:`, as SettingFieldStatus does.

Closes #4934

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7b18398-2151-485c-8aa7-a4cd9b6b5d12
Commits

Reviewing files that changed from the base of the PR and between 3e96eb8 and d0f1f3a.

Files selected for processing: 1

  • web/src/components/admin/ConnectionCheckAction.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-triage silo-triage Bot added the size/S 0–49 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T07:30:45.745302Z d0f1f3a PR opened
🔒 Security Review ✅ Completed 2026-11-21T07:32:01.599669Z d0f1f3a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026
@Quick104
Quick104 merged commit b0d1372 into main Nov 21, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/connection-check-failure-contrast branch November 21, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/S 0–49 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Failed connection check text is below 4.5:1 contrast on the admin's dark panel

1 participant