Repository navigation
fix(web): keep badges readable on watched calendar cards #4807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−28
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S1 · Low. A watched season-premiere badge loses contrast when bright artwork sits behind it and the server uses the shipped red accent (
#ef4444). In a fixture rendering both revisions with the app CSS, the highest sampled text contrast fell from 2.92:1 to 1.31:1 in Chromium (1.29:1 in Firefox). Moving the badge out of the grayscale layer leaves red text over a translucent red tint on a mid-grey poster, so text and fill end up close in luminance.Suggested repair: give the premiere badge an opaque fill and a foreground that reaches 4.5:1 against it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The badge's translucent fill (
bg-primary/20 text-primaryinupcomingEventPresentation.ts) causes this, and the same badge fails on unwatched bright posters too (about 1:1 with the default accent). Before this change the watched badge also failed (2.92:1), because the grayscale turned it grey on grey. Both values are well under 4.5:1. This change keeps that line untouched because #4780 replaces it with an opaque fill, which makes the badge's contrast independent of the poster behind it. With that fill, a watched badge measures the same as an unwatched one. Until #4780 lands, this case moves from one failing value to another, so #4780 should merge first or together with this PR.🤖 Claude Code (claude-opus-5-5)