Skip to content

fix(web): keep badges readable on watched calendar cards - #4807

Merged
Quick104 merged 1 commit into
mainfrom
fix/watched-card-badge-contrast
Nov 21, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/watched-card-badge-contrast

Conversation

@Quick104

@Quick104 Quick104 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: changes #1136 C1 (minor: on watched cards the premiere badge now keeps its accent colour instead of turning grey, so premieres stand out more)

Other clients: Apple N/A (watched calendar cards aren't dimmed); Android: Android TV parity issue to follow (it dims the whole card, badges included; the phone app doesn't dim); Roku N/A (watched calendar cards show a check disc and are not dimmed)

On the web calendar, a watched event card set its whole poster area to 60% opacity and grayscale. That area also holds the badge row and the watched check mark, so the PREMIERE, NEW SEASON, FINALE, DIGITAL and PHYSICAL labels faded along with the artwork. The premiere badge suffered most: with every shipped accent preset it fell to roughly 1.5–3:1 on a watched card, well below WCAG AA's 4.5:1.

This change dims and greys only the artwork, which stays as dark as before. Badges and the check mark sit above it at full strength.

Approach

CalendarEventCard now wraps the poster image, thumbhash placeholder, default artwork and bottom scrim in an inner layer, and only that layer gets opacity-60 grayscale when the event is watched. The badges and check mark stay outside it. A watched card's poster area takes the page background, so the dimmed artwork blends with the same colour as before rather than the lighter card surface. The card border no longer dims.

The home row cards (SectionItemCard, ContinueWatchingCard) show the same badges but don't dim watched items, so they need no change.

The premiere badge's translucent fill is still hard to read on bright posters and with some accents, on watched and unwatched cards alike. That fill belongs to #4780, so this PR leaves upcomingEventPresentation.ts alone.

Validation

  • Before and after on the real component: a Silo dev deployment had no watched calendar entries with badges, so a temporary dev-only harness route (removed before commit) rendered CalendarEventCard with fixture events on a dark poster, a bright poster and no poster. Captures cover 1400, 820 and 390 px, the default, amber and sky accents, and high contrast.
  • Contrast, sampled from the captures (approximate): on a dark poster the watched premiere badge went from 4.68 to 9.27:1 with the default accent, 2.98 to 6.10:1 with amber, and 2.45 to 5.12:1 with sky and high contrast on. With no poster, amber went from 2.70 to 5.43:1. Watched finale went from 6.42 to 15.29:1. On dark posters and default artwork, watched badges now measure the same as unwatched ones. On a bright poster the premiere badge stays at about 1–2:1 before and after, as it does on unwatched cards; fix(web): keep accent-colored text readable on Cinema Dark #4780's opaque fill addresses that.
  • eslint on the changed file and the web typecheck pass. No test was added: the change is presentational, and the before/after captures are the proof.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/watched-card-badge-contrast/

Surface and build: web calendar event card, rendered in a temporary harness with fixture events; before on main, after on this branch.

Risks

None identified.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

Council review

Background review: 1 round, reviewed eaccaf9

Member Round 1
Sol (gpt-6.2-sol, xhigh) 8/10
Opus (claude-opus-5-5, high) 9/10
Gemini (gemini-4-neon, xhigh) 10/10

Background review: Opus and Gemini found nothing. Sol's one finding (S1) is the bright-poster premiere badge with the red accent, which is the translucent fill #4780 replaces; answered in its thread, and it means #4780 should merge first or together with this PR.

Visual review: 2 rounds, final captures from this branch's component code

Member Round 1 Round 2
Sol better, 8/10 better, 8/10
Opus better, 7/10 better, 7/10
Gemini better, 7/10 better, 7/10

Fixed: dimmed dark posters looked lighter than before, because the artwork blended with the card surface; the poster area now takes the page background on watched cards, and sampled pixels match main. Answered: the premiere badge stays unreadable on bright posters (it is on unwatched cards too; #4780 replaces its translucent fill); the watched check-mark circle blends into dark posters and overlaps the default-artwork icon (both unchanged from main, outside this fix); the watched card border no longer dims (intended).

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code, Codex, Antigravity, Playwright (Chromium) for captures and contrast sampling
  • Model(s): claude-opus-5-5 (implementation); gpt-6.2-sol, claude-opus-5-5, gemini-4-neon (review)
  • Involvement: Fully AI-generated, not yet human verified
  • Adversarial review: code-review at the low level (one pass over the diff, no findings); the plan round was skipped as a mechanical fix (root cause shown in source, a few-line change with nothing added); simplify pass made no changes. See Council review for the visual review and the background review.

🤖 Generated with Claude Code

Note

Fix watched-state dimming applying to badges on CalendarEventCard

The watched opacity and grayscale styles previously sat on the outer image container, so they also dimmed badges and overlays. In CalendarEventCard.tsx, those styles now target a new absolute layer around the thumbnail, poster or default artwork, and bottom gradient. Badges stay outside that layer. The outer container uses the page background color when the event is watched.

Macroscope summarized eaccaf9.

A watched calendar card dimmed and greyed its whole poster layer, so the
premiere, finale, digital and physical badges and the check mark faded
with the artwork. The premiere badge fell well below 4.5:1 with every
shipped accent. Dim only the artwork layer and leave the badges and check
mark at full strength.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 20d681cb-4055-40b8-bf50-7b2182159221
Commits

Reviewing files that changed from the base of the PR and between 57fb867 and eaccaf9.

Files selected for processing: 1

  • web/src/components/calendar/CalendarEventCard.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:09:09.688518Z eaccaf9 PR opened
🔒 Security Review ✅ Completed 2026-11-21T03:11:22.224583Z eaccaf9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-kody

silo-kody Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@silo-triage silo-triage Bot added bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish labels Nov 21, 2026

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review (gpt-6.2-sol, reviewed eaccaf9)

One low-severity finding, posted by the /silo run on the reviewer's behalf because the reviewer's own post hit a GitHub rate limit. Score: 8/10.

page background behind it keeps the dimmed artwork as dark as
when the whole card faded into the page. */}
<div
className={`absolute inset-0 ${watched ? "opacity-60 grayscale" : ""}`}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S1 · Low. A watched season-premiere badge loses contrast when bright artwork sits behind it and the server uses the shipped red accent (#ef4444). In a fixture rendering both revisions with the app CSS, the highest sampled text contrast fell from 2.92:1 to 1.31:1 in Chromium (1.29:1 in Firefox). Moving the badge out of the grayscale layer leaves red text over a translucent red tint on a mid-grey poster, so text and fill end up close in luminance.

Suggested repair: give the premiere badge an opaque fill and a foreground that reaches 4.5:1 against it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge's translucent fill (bg-primary/20 text-primary in upcomingEventPresentation.ts) causes this, and the same badge fails on unwatched bright posters too (about 1:1 with the default accent). Before this change the watched badge also failed (2.92:1), because the grayscale turned it grey on grey. Both values are well under 4.5:1. This change keeps that line untouched because #4780 replaces it with an opaque fill, which makes the badge's contrast independent of the poster behind it. With that fill, a watched badge measures the same as an unwatched one. Until #4780 lands, this case moves from one failing value to another, so #4780 should merge first or together with this PR.

🤖 Claude Code (claude-opus-5-5)

@Quick104
Quick104 merged commit 182a62d into main Nov 21, 2026
23 checks passed
@Quick104
Quick104 deleted the fix/watched-card-badge-contrast branch November 21, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: polish Annoyance, cosmetic, or nice-to-have priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant