Skip to content

fix(web): open the standard edition before comparing quality - #4511

Merged
Quick104 merged 1 commit into
mainfrom
fix/default-item-edition
Nov 18, 2026
Merged

Quick104 merged 1 commit into
mainfrom
fix/default-item-edition

Conversation

@Quick104

@Quick104 Quick104 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A
Validation tasks: none (the edition label still shows; #199's detail case does not cover which edition opens first)

Other clients: Apple Silo-Server/silo-apple#1220; Android Silo-Server/silo-android#996; Roku Silo-Server/silo-roku#98

When a movie or episode has several editions and the viewer has never played it, the web detail page opens on whichever edition has the best file. A movie with a 1080p standard cut and a 2160p Dolby Vision extended cut opens on the extended cut, so pressing Play starts a longer cut the viewer never chose.

This change makes the page choose the edition by name first: an unnamed or standard edition, then a theatrical one, then any other. Quality decides only between editions in the same group. An edition the viewer picked, their last played edition, or the edition of their last played file still wins, as before.

Approach

bestEditionAuto in versionRankingUtils.ts now compares only the editions in the most preferred name group. Inside that group the quality comparison is unchanged: a file within the quality cap, then higher resolution, then HDR, then server order. Version Auto inside the chosen edition is unchanged.

Apple, Android and Roku follow the same rule since #4070, so each needs the same change. docs/catalog-api.md now states the rule next to the version order, so the four clients have one written reference.

Validation

  • vitest run src/pages/ItemDetail: 23 passed. The new ranking test fails on main and passes on this branch.
  • tsc -b, eslint and prettier on the touched files: clean. scripts/typecheck.mjs did not run here because tsrs is not installed on this host.

Evidence

Evidence: https://evidence.siloserver.org/r/silo-server/pr-4511/

Surface and build: web detail page for a movie with a 1080p standard cut and a 2160p Dolby Vision extended cut, opened by a profile with no history for it, on shared dev. main at e8de111 opens on the extended cut; this branch at 1f7cad3 opens on Standard. The mobile-width layout is unchanged.

Risks

Viewers with no history on a multi-edition title now land on the standard cut, which may be the lower-quality file. The Edition picker still lists every cut.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

AI Disclosure

  • Harness: Claude Code in T3 Code
  • Tool(s): Claude Code
  • Model(s): claude-opus-5-5
  • Involvement: Fully AI-generated, human verified
  • Adversarial review: n/a

🤖 Generated with Claude Code

With no history for an item, the detail page picked the edition whose Auto
file had the best quality and used the edition name only to break ties, so a
movie with a 1080p standard cut and a 2160p extended cut opened on the
extended cut. The page now chooses by name first (unnamed or standard, then
theatrical, then other cuts) and compares quality only among the cuts in that
group. A picked, remembered, or last played edition still wins.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dbeb5382-844e-47ea-b620-fc28f105fda8
Commits

Reviewing files that changed from the base of the PR and between e8de111 and 1f7cad3.

Files selected for processing: 3

  • docs/catalog-api.md
  • web/src/pages/ItemDetail/components/versionRankingUtils.test.ts
  • web/src/pages/ItemDetail/components/versionRankingUtils.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@silo-kody

silo-kody Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T19:02:42.099866Z 1f7cad3 PR opened
🔒 Security Review ✅ Completed 2026-11-18T19:05:34.795485Z 1f7cad3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@silo-triage silo-triage Bot added bug Something isn't working impact: playback Can't play, stalls, or wrong media priority: P2 Limited scope, workaround exists, or polish labels Nov 18, 2026
@Quick104
Quick104 merged commit 66105aa into main Nov 18, 2026
19 checks passed
@Quick104
Quick104 deleted the fix/default-item-edition branch November 18, 2026 19:33
Quick104 added a commit to Silo-Server/silo-apple that referenced this pull request Nov 18, 2026
With no history, the detail page picked the edition whose Auto file
compared best on quality and used the edition name only as a tiebreak,
so a 2160p Dolby Vision Extended Cut won over a 1080p standard cut.
Compare the name class first (standard or unnamed, then theatrical,
then the rest), then quality among editions of that class. This
matches the web change in Silo-Server/silo-server#4511.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Quick104 added a commit to Silo-Server/silo-roku that referenced this pull request Nov 18, 2026
With nothing played, the detail page compared each edition's Auto file
first (fits the quality preference, then resolution, then HDR) and used
the edition's name only to break a tie. A movie with a Standard 1080p SDR
cut and an Extended Cut in 2160p Dolby Vision opened on the Extended Cut.

The edition's name now decides first: the unnamed or a standard or
default cut, then a theatrical one, then any other. Only editions of the
best name class present compare their Auto files, by the same quality
rule as before, then the server's edition order. A last played edition
or file still wins, and Version Auto inside the edition is unchanged.
This is the rule Silo-Server/silo-server#4511 sets for every client.

docs/spec.md and AG-225 record the new order.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Quick104 added a commit to Silo-Server/silo-android that referenced this pull request Nov 18, 2026
With no history, the detail page now picks the edition by name first:
unnamed or standard, then theatrical, then any other cut. Only the cuts
in the best class present compete on quality (fit, resolution, HDR,
server order), so a 2160p HDR Extended Cut no longer wins over a 1080p
Standard edition. Matches the web change in Silo-Server/silo-server#4511.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working impact: playback Can't play, stalls, or wrong media priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant