Repository navigation
fix(web): open the standard edition before comparing quality - #4511
Conversation
With no history for an item, the detail page picked the edition whose Auto file had the best quality and used the edition name only to break ties, so a movie with a 1080p standard cut and a 2160p extended cut opened on the extended cut. The page now chooses by name first (unnamed or standard, then theatrical, then other cuts) and compares quality only among the cuts in that group. A picked, remembered, or last played edition still wins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 31 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
With no history, the detail page picked the edition whose Auto file compared best on quality and used the edition name only as a tiebreak, so a 2160p Dolby Vision Extended Cut won over a 1080p standard cut. Compare the name class first (standard or unnamed, then theatrical, then the rest), then quality among editions of that class. This matches the web change in Silo-Server/silo-server#4511. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
With nothing played, the detail page compared each edition's Auto file first (fits the quality preference, then resolution, then HDR) and used the edition's name only to break a tie. A movie with a Standard 1080p SDR cut and an Extended Cut in 2160p Dolby Vision opened on the Extended Cut. The edition's name now decides first: the unnamed or a standard or default cut, then a theatrical one, then any other. Only editions of the best name class present compare their Auto files, by the same quality rule as before, then the server's edition order. A last played edition or file still wins, and Version Auto inside the edition is unchanged. This is the rule Silo-Server/silo-server#4511 sets for every client. docs/spec.md and AG-225 record the new order. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
With no history, the detail page now picks the edition by name first: unnamed or standard, then theatrical, then any other cut. Only the cuts in the best class present compete on quality (fit, resolution, HDR, server order), so a 2160p HDR Extended Cut no longer wins over a 1080p Standard edition. Matches the web change in Silo-Server/silo-server#4511. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Problem
Related issue: N/A
Validation tasks: none (the edition label still shows; #199's detail case does not cover which edition opens first)
Other clients: Apple Silo-Server/silo-apple#1220; Android Silo-Server/silo-android#996; Roku Silo-Server/silo-roku#98
When a movie or episode has several editions and the viewer has never played it, the web detail page opens on whichever edition has the best file. A movie with a 1080p standard cut and a 2160p Dolby Vision extended cut opens on the extended cut, so pressing Play starts a longer cut the viewer never chose.
This change makes the page choose the edition by name first: an unnamed or standard edition, then a theatrical one, then any other. Quality decides only between editions in the same group. An edition the viewer picked, their last played edition, or the edition of their last played file still wins, as before.
Approach
bestEditionAutoinversionRankingUtils.tsnow compares only the editions in the most preferred name group. Inside that group the quality comparison is unchanged: a file within the quality cap, then higher resolution, then HDR, then server order. Version Auto inside the chosen edition is unchanged.Apple, Android and Roku follow the same rule since #4070, so each needs the same change.
docs/catalog-api.mdnow states the rule next to the version order, so the four clients have one written reference.Validation
vitest run src/pages/ItemDetail: 23 passed. The new ranking test fails onmainand passes on this branch.tsc -b, eslint and prettier on the touched files: clean.scripts/typecheck.mjsdid not run here becausetsrsis not installed on this host.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4511/
Surface and build: web detail page for a movie with a 1080p standard cut and a 2160p Dolby Vision extended cut, opened by a profile with no history for it, on shared dev.
mainat e8de111 opens on the extended cut; this branch at 1f7cad3 opens on Standard. The mobile-width layout is unchanged.Risks
Viewers with no history on a multi-edition title now land on the standard cut, which may be the lower-quality file. The Edition picker still lists every cut.
Checklist
AI Disclosure
🤖 Generated with Claude Code