Repository navigation
fix(detail): open the standard edition before comparing quality - #996
Conversation
With no history, the detail page now picks the edition by name first: unnamed or standard, then theatrical, then any other cut. Only the cuts in the best class present compete on quality (fit, resolution, HDR, server order), so a 2160p HDR Extended Cut no longer wins over a 1080p Standard edition. Matches the web change in Silo-Server/silo-server#4511. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Visible effect missing evidence: Suggested fix: No diff; add the requested captures to the Evidence section. Automated check: Macroscope check run agent (gpt-6-luna). Evidence was not reviewed for correctness. Posted via Macroscope — Visible change evidence |
Problem
Related issue: N/A
Validation tasks: none passed. The Detail case of #7 and #8 ("edition label shown") still holds; only the edition the page opens on changes.
Other clients: Web Silo-Server/silo-server#4511; Apple Silo-Server/silo-apple#1220; Roku Silo-Server/silo-roku#98
When a viewer opens a movie or episode with several editions and has no history for it, the phone and TV detail pages pick the edition by file quality, with the edition name only breaking ties. A movie with "Standard" at 1080p SDR and "Extended Cut" at 2160p Dolby Vision therefore opens on Extended Cut. This change picks the edition by name first, so that page opens on Standard. The edition decides which film you watch; quality only decides how it looks.
Approach
The no-history rule in the shared
DetailVersionSelectornow runs in this order, matching the web change in Silo-Server/silo-server#4511:An edition the viewer picked,
last_edition_key, and the edition oflast_file_idstill take precedence, unchanged. Phone and TV both call the shared selector, so both get the change. The phone code changes only in a doc comment that describes the rule.Validation
./gradlew :shared:testDebugUnitTest: passed, including the updated selector test (Standard 1080p SDR vs Extended 2160p HDR with no history opens Standard)../gradlew :androidApp:testDebugUnitTest --tests '*detail*'and./gradlew :androidTvApp:testDebugUnitTest --tests '*detail*': passed../gradlew :androidApp:lintDebug: no new findings.testDebugUnitTestacross all modules, the other lint tasks, and the app builds. No device or emulator check.Evidence
No device capture. The change is in shared selection logic, so I checked it with unit tests: the shared selector test covers the no-history cases (name class first, then quality within a class), and the phone and TV detail tests pass on commit ade7029.
Risks
Viewers with no history on a multi-edition title will now see a different default edition when a non-standard cut has the better file. History and explicit picks are unaffected.
Checklist
AI Disclosure
🤖 Generated with Claude Code
Note
Prefer the standard edition before comparing quality in
openingEditionChanges no-history edition selection in
openingEdition(DetailVersionSelector.kt). The candidate set is now editions with the lowest preference value (e.g. the standard or unnamed cut), picked by name before comparing Auto-file fit, resolution, HDR, and server order. Quality comparisons still apply within the same preference class. Updates the selector tests and the docs in MediaSelectors.kt. Risk: no-history playback may open a lower-quality preferred cut instead of the highest-quality file.Macroscope summarized ade7029.