Repository navigation
feat(settings): add a setting that turns Next Up off #4501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
| */ | ||
|
|
||
| export const SETTINGS_API_VERSION = 1; | ||
| export const SETTINGS_REVISION = 29; | ||
| export const SETTINGS_REVISION = 30; | ||
|
|
||
| export interface SettingSuggestedOption { | ||
| value: string; | ||
|
|
@@ -239,6 +239,8 @@ export const SETTING_KEYS = { | |
| PLAYBACK_INTRO_SKIP_MODE: "playback.intro_skip_mode", | ||
| /** Maximum bitrate */ | ||
| PLAYBACK_MAX_BITRATE_KBPS: "playback.max_bitrate_kbps", | ||
| /** Show Next Up */ | ||
| PLAYBACK_NEXT_UP_ENABLED: "playback.next_up_enabled", | ||
| /** Next up prompt */ | ||
| PLAYBACK_NEXT_UP_PROMPT_SECONDS: "playback.next_up_prompt_seconds", | ||
| /** Preferred quality */ | ||
|
|
@@ -804,6 +806,21 @@ export const SETTING_DEFINITIONS: Record<SettingKey, SettingDefinition> = { | |
| minimum: 100, | ||
| maximum: 200000, | ||
| }, | ||
| "playback.next_up_enabled": { | ||
| key: "playback.next_up_enabled", | ||
| type: "boolean", | ||
| nullable: false, | ||
| persistence: "remote", | ||
| introducedIn: 30, | ||
| scopes: ["profile", "profile_device"], | ||
|
Comment on lines
+809
to
+815
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Web playback ignores the profile-wide Next Up off setting A profile-level Prompt for LLMTalk to Kody by mentioning @kody Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bug in this PR. This PR adds the setting to the contract and keeps it off the web device settings screen (deviceSettingGroups HIDDEN_KEYS). The web player and settings picker apply it in #4503, which stacks on this one. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| scopeIntroducedIn: [30, 30], | ||
| resolutionOrder: ["profile_device", "profile", "default"], | ||
| defaultValue: true, | ||
| label: "Show Next Up", | ||
| description: "Show the Next Up card near the end of an episode.", | ||
| category: "playback", | ||
| control: "switch", | ||
| }, | ||
| "playback.next_up_prompt_seconds": { | ||
| key: "playback.next_up_prompt_seconds", | ||
| type: "integer", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.