Skip to content

feat(settings): add a setting that turns Next Up off - #4501

Open
Rhainland wants to merge 2 commits into
Silo-Server:mainfrom
Rhainland:feat/settings-next-up-enabled
Open

Rhainland wants to merge 2 commits into
Silo-Server:mainfrom
Rhainland:feat/settings-next-up-enabled

Conversation

@Rhainland

@Rhainland Rhainland commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: Discussion #4443
Validation tasks: none

Other clients: Apple Silo-Server/silo-apple#1219; Android Silo-Server/silo-android#995; Roku Silo-Server/silo-roku#97; Web #4503

Viewers who would rather go straight back after an episode have no way to turn Next Up off. Auto-play next only stops the countdown; the Next Up screen still opens before or at the end of every episode. Discussion #4443 asked for an off switch alongside timing Next Up from the end of the file.

This adds playback.next_up_enabled, a boolean setting at manifest revision 30. When it is false, no client opens Next Up, runs a countdown or starts the next episode; the episode plays to its end and the player closes the way its Close action does. The client pull requests listed above use it.

Approach

  • New key in contracts/settings/v1/manifest.json (revision 29 → 30): boolean, default true, scopes profile and profile_device, label "Show Next Up". playback.next_up_prompt_seconds is unchanged and still decides when Next Up opens while this is true, so a client can show both as one picker with an Off choice.
  • docs/settings-api.md gains a Next Up section that states both rules, including that the seconds count from the end of the file, never from a credits marker.
  • Regenerated bindings (internal/settingskeys/keys.go, web/src/lib/settingsContract.ts) and conformance fixtures.
  • The web device settings screen hides the key; the web Settings → Playback picker owns it.

Clients that predate the key never send or read it and keep showing Next Up, so older apps are unaffected. jellycompat is not involved: Jellyfin clients run their own Next Up.

Validation

  • Go: go build, go vet, gofmt, go mod tidy -diff clean. make test-go, make lint-changed and make lint-router-recovery pass; see Evidence.
  • Contracts: make verify-settings-bindings-all, the apiv2 checks, verify-local-paths, verify-size-ratchet, verify-migrations and the router artifact test pass.
  • Android and Apple vendor this manifest and pass their settings conformance tests at revision 30.

Evidence

No screen changes in this pull request; the client pull requests show the setting. A local server with this change, and a new profile:

GET /api/v2/settings/contract/capabilities          (trimmed)
{"api_version": 1, "manifest_revision": 30, "supports_batched_effective": true, ...}

GET /api/v2/settings/values/effective?keys=playback.next_up_enabled&keys=playback.next_up_prompt_seconds
{"items": [
  {"key": "playback.next_up_enabled", "value": true, "source": "default", "definition_revision": 30},
  {"key": "playback.next_up_prompt_seconds", "value": 30, "source": "default", "definition_revision": 30}
], "revision": 30}

On main the manifest is at revision 29 and has no playback.next_up_enabled.

Risks

None identified. The key is additive; a server on this build answers revision 30, and older clients ignore the new key.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.
  • Each test this pull request adds meets "Decide what to test" in CONTRIBUTING.md.
  • The Evidence section shows every change a user can see, or how I checked a change nobody sees.

AI Disclosure

  • Harness: Claude Code, running in T3 Code
  • Tool(s): Claude Code, GitHub CLI, Codex CLI (review only)
  • Model(s): claude-opus-5-5; reviewers gpt-6.2-sol, gpt-6.2-astra, claude-fable-5-2
  • Involvement: Fully AI-generated, human verified
  • Adversarial review: four independent reviews (gpt-6.2-sol, gpt-6.2-astra, claude-opus-5-5, claude-fable-5-2) of the branch diff for correctness, repository standards and the discussion's request; the real findings were fixed before opening

Note

Add playback.next_up_enabled setting to turn Next Up off

Adds a new remote boolean setting playback.next_up_enabled, defined in the settings manifest and web contract, with a default of true and resolution at profile and profile-device scopes. Bumps the settings contract revision from 29 to 30 and updates conformance fixtures. The setting stays hidden in web device settings until the web player applies it. Risk: consumers pinned to revision 29 of contracts/settings/v1/manifest.json or the old conformance fixtures will see a revision mismatch; settingskeys.Remote and web SETTING_KEYS gain a new key that older code does not know.

Macroscope summarized 6c1ca22.

Viewers who would rather go back to the series page at the end of an
episode cannot turn the Next Up card off: Auto-play Next only stops the
countdown, and the card still opens.

Add playback.next_up_enabled at manifest revision 30, a boolean stored per
profile with a per-device override and default true. False means no card,
no countdown and no automatic next episode; the episode plays out and the
player closes as its Close action does. next_up_prompt_seconds keeps deciding when
the card opens while it is on, and the settings docs now state that it
counts from the end of the file, not from a credits marker. Clients that
predate the key keep showing Next Up.

The web device settings screen hides the key until the web player applies
it.
@silo-triage silo-triage Bot added the size/M 50–199 added + deleted lines (all files); change volume, not priority. label Nov 18, 2026
@silo-kody

silo-kody Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Silo Kody — review complete

Review finished. Check the inline comments for findings and verify each suggestion against the code and tests.

Reviewing changes in Silo
  • Include the related issue, expected behavior, and validation steps in the PR description.
  • For API changes, describe the effect on Apple and Android clients and Jellyfin compatibility.
  • For plugin changes, identify the affected SDK contract, plugin, and catalog entry.
  • Follow this repository's AGENTS.md and CONTRIBUTING.md.
  • Request another review with @kody start-review in a PR comment.
  • React with 👍 or 👎 to give feedback on individual suggestions.
Review settings
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ❌

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Walkthrough

The settings contract adds playback.next_up_enabled, a remote boolean that defaults to true and supports profile and profile-device scopes. Server and web settings registries, conformance fixtures, validation tests, and API documentation are updated for the setting.

Changes: Next Up setting

Layer / File(s) Summary
Define the setting contract
contracts/settings/v1/manifest.json, web/src/lib/settingsContract.ts, internal/settingskeys/keys.go
The settings revision advances to 30. The manifest and web contract define playback.next_up_enabled as a remote boolean with a default of true; server keys include the new setting.
Register setting handling
internal/settingskeys/keys.go, web/src/lib/deviceSettingGroups.ts
The server adds the setting to its remote key list. The web client hides it from device-setting groups.
Update validation and documentation
contracts/settings/v1/conformance.json, web/src/lib/settingsConformance.json, internal/settingscontract/contract_test.go, docs/settings-api.md
Conformance fixtures expect the setting to resolve to true by default. The contract test accepts false, and the API documentation describes the setting behavior and resolution rules.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: memnos, quick104

Merge Risk: Low · up to fd613

The new Next Up setting is added consistently across the contract, server, and fixtures. The documentation says it disables Next Up on all clients, but the web player does not apply it yet, so the docs should note that exception. This is a small follow-up and does not block merging.

Security architecture risk: Minimal · up to fd613

This adds a playback preference through existing settings controls. The inspected change establishes no material weakening of access boundaries, state ownership or recovery guarantees. Actual playback behavior still depends on client support.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The newly controllable state is one boolean per profile or profile-device identity within an account's settings. Existing household authorization governs targeting another profile, named devices require registry membership, and PostgreSQL identities include user, key, scope and applicable profile/device identifiers. The inspected addition does not confer broader authority.

Trust Boundaries and Controls

  • observed — Request-supplied keys and scopes pass remote-definition lookup and scope-identity checks before mutation. The contract separately enforces allowed scopes, and values pass normalization backed by non-nullable, strict boolean validation before storage. Registering this key does not bypass those checks.

Resilience and Maintainability Implications

  • observed — The new key has no mirrored companion and follows the existing single-row desired-state mutation path. PostgreSQL serializes account settings mutations, commits successful work and defers rollback on failure. Where a mutation ID is supplied, the same transaction records or replays its result and rejects conflicting reuse. Clearing deletes the explicit row transactionally, restoring normal inheritance; another clear returns not found rather than recreating state. These mechanisms are unchanged from the PR base.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: a new setting, playback.next_up_enabled, that turns Next Up off. It follows the conventional commit format and matches the manifest, bindings, and docs changes in the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is directly related to the changeset. It explains the new playback.next_up_enabled boolean setting at manifest revision 30, its behavior when false, the manifest, docs, generated bin…
Full details: Title check

Explanation

The title names the main change: a new setting, playback.next_up_enabled, that turns Next Up off. It follows the conventional commit format and matches the manifest, bindings, and docs changes in the changeset.

Full details: Description check

Explanation

The description is directly related to the changeset. It explains the new playback.next_up_enabled boolean setting at manifest revision 30, its behavior when false, the manifest, docs, generated bindings, and web device settings hiding, plus validation and risk notes. The level of detail is more than sufficient.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment on lines +809 to +815
"playback.next_up_enabled": {
key: "playback.next_up_enabled",
type: "boolean",
nullable: false,
persistence: "remote",
introducedIn: 30,
scopes: ["profile", "profile_device"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug high

Web playback ignores the profile-wide Next Up off setting

A profile-level false set by another client is ignored, so the web player can still display Next Up and auto-play. Read the effective playback.next_up_enabled value and suppress both the card and automatic advancement when it is false.

Prompt for LLM
File web/src/lib/settingsContract.ts, lines 809-815:

Web playback ignores the profile-wide Next Up off setting

A profile-level `false` set by another client is ignored by the web player, which still displays Next Up and can auto-play despite the new setting's contract. Read the effective `playback.next_up_enabled` value in the player and suppress both the card and automatic advancement when it is false.

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug in this PR. This PR adds the setting to the contract and keeps it off the web device settings screen (deviceSettingGroups HIDDEN_KEYS). The web player and settings picker apply it in #4503, which stacks on this one.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. The suggestion is out of scope for PR #4501: this PR adds the contract key and hides it from device settings, while the stacked PR #4503 implements the web player and settings picker behavior.

I withdraw the finding for this PR.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8022b0d5-ea02-4be3-b499-eccaf4c9414e
Commits

Reviewing files that changed from the base of the PR and between e8de111 and fd61354.

Files selected for processing: 8

  • contracts/settings/v1/conformance.json
  • contracts/settings/v1/manifest.json
  • docs/settings-api.md
  • internal/settingscontract/contract_test.go
  • internal/settingskeys/keys.go
  • web/src/lib/deviceSettingGroups.ts
  • web/src/lib/settingsConformance.json
  • web/src/lib/settingsContract.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread docs/settings-api.md Resolved

@Quick104 Quick104 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cleanup finding, inline. The contract change, the generated bindings, and the conformance fixtures agree with each other, and older clients ignore the new key.

🤖 Claude Code (claude-opus-5-5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Quick104

Copy link
Copy Markdown
Contributor

Review summary

Reviewed head: 6c1ca22

The PR adds playback.next_up_enabled (boolean, default true, profile and profile-device scopes) at manifest revision 30. The manifest, the Go and TypeScript bindings, both conformance fixtures and the new section in docs/settings-api.md agree with each other. No other open pull request touches the manifest, so revision 30 doesn't collide with anything. A client that predates the key never reads it and keeps showing Next Up.

Addressed

  • The contract test row for false repeated what the existing playback.auto_play_next boolean rows already check. Removed in 6c1ca22.

Other feedback

  • Kody (web player ignores the key) and CodeRabbit (docs should note the web exception) both withdrew after the author's replies. I agree: this PR keeps the key off the web device settings screen, and the web player applies it in feat(web): let Show Next Up be turned off #4503.

Left for the maintainers

  • The manifest's new label and description ("Show Next Up", "Show the Next Up card near the end of an episode.") aren't in the silo-translations catalog as settingsManifest.playback.next_up_enabled.*. Until someone runs make import-settings-manifest there, any screen that renders this manifest text shows it in English. The catalog's vendored manifest is already at revision 28 while main is at 29, so this joins an import that is already pending. The web picker in feat(web): let Show Next Up be turned off #4503 uses its own catalog keys (silo-translations#86).

Validated features: none affected. The default is true, and no client reads the key until its own pull request lands. The Series validation tasks cover Next Up on each client, so the client pull requests are the ones to check against them.

Validation: CI passed on fd61354. The author's evidence page shows the key resolving to its default through /api/v2/settings/values/effective at revision 30. No test in this PR exercises the change; the contract checks (make verify-settings-bindings-all) catch binding drift.

User manual: Silo-Server/siloserver.org#409 covers the Off choice and the timing change.

Other clients: Apple Silo-Server/silo-apple#1219, Android Silo-Server/silo-android#995, Roku Silo-Server/silo-roku#97 and web #4503 are linked. jellycompat is unaffected.

Fit: 8/10 · Readiness: 9/10 — conditional (assuming CI is green)

  • Fit: Discussion Next Up "end" detection should be based on file end and not the credits marker #4443 asked for a way to turn Next Up off, and whether you want Next Up depends on the viewer, so a per-profile switch is a reasonable answer. Next Up stays on by default, and clients can fold the switch into the existing timing picker as an Off choice. It still adds one setting to a contract that locks at 1.0, which is the reason it isn't higher.
  • Readiness: the change is additive, the generated files match the manifest, and no defect remains. The client behavior it describes ships in the client pull requests.

🤖 Claude Code (claude-opus-5-5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: P2 Limited scope, workaround exists, or polish size/M 50–199 added + deleted lines (all files); change volume, not priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants