Repository navigation
Conversation
…arker The Show Next Up setting offers "At end" and "N seconds before end", but on an episode with a credits marker both apps opened the card at the credits start whatever was chosen. The TV player never read the setting at all. Both players now open Up Next when playback crosses the chosen number of seconds before the end of the file, and only when the stream ends for "At end", as the iOS and tvOS player already does. Credits markers still drive Skip Credits; skipping credits that run to the end ends the stream, which opens the card. The TV settings screen now assumes the same 30-second default as the settings store and the server. Fixes Silo-Server#910
…credits Moving Up Next to the end of the file also moved the point at which the TV player treats an episode as finished for the series page. Leaving during the closing credits then opened the series on the episode just watched, and leaving after an early prompt during the final scene opened it on the next one. Record the closing-credits crossing on its own again, and count the Up Next prompt only when the stream has ended. Update the comments that still described the credits-based trigger.
|
Warning Review limit reachedThis organization requires a seat for paid usage-based reviews, including automatic and on-demand reviews. Ask an admin to assign a seat or enable paid usage-based reviews for users without a seat in Billing. Next included review available in 16 minutes. View limit details
|
Silo Kody — review completeReview finished. Check the inline comments for findings and verify each suggestion against the code and tests. Reviewing changes in Silo
Review settingsReview OptionsThe following review options are enabled or disabled:
|
|
Up Next now opens at the configured point before the file ends instead of at the credits marker ( Suggested fix: Attach the recordings under Evidence, or publish them on evidence.siloserver.org and link the evidence page. Automated check: Macroscope check run agent (gpt-6-luna). Evidence was not reviewed for correctness. Posted via Macroscope — Visible change evidence |
| val promptStart = duration - promptSeconds | ||
| return previousPosition < promptStart && position >= promptStart |
There was a problem hiding this comment.
Short episodes never cross the configured Up Next prompt point
Episodes at or below the configured offset end without showing Up Next because promptStart is nonpositive and playback starts at zero. Handle this boundary explicitly so the prompt can appear during playback.
Prompt for LLM
File shared/src/commonMain/kotlin/org/siloserver/silo/domain/player/NextUpPrompt.kt, lines 22-23:
Short episodes never cross the configured Up Next prompt point
A file whose duration is less than or equal to the configured offset never shows Up Next before ending because its prompt point is nonpositive and playback positions start at zero. Handle this boundary explicitly so short episodes can surface the prompt during playback.
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
There was a problem hiding this comment.
Same as main. The phone already computed the point as duration minus the lead time and needed a forward crossing, so a file no longer than the lead never opened the card early; the TV never used the setting at all. Such a file still gets Up Next when the stream ends (onApproachingEnd(videoEnded = true)). The longest lead is 2 minutes, so this only affects clips, not episodes.
There was a problem hiding this comment.
That context changes the assessment: short files still get Up Next when playback ends, so the suggestion overstates the impact. The phone’s behavior is also unchanged from main; the TV’s prior behavior was different because it did not use the setting.
There is still a boundary case: for a file no longer than the configured lead time, the prompt cannot open early under the crossing logic. Whether to change that is a product decision rather than necessarily a regression in this PR. I would not treat it as blocking #994.
Problem
Closes #910
Related issue: Silo-Server/silo-server Discussion #4443; #927 (likely fixed, not re-tested)
Validation tasks: changes #347 C9, #348 C9 (Next Up timing; not run yet); may change #321 C1, #322 C1 (#927, see below)
Other clients: Apple N/A (already times Next Up from the end of the file); Roku N/A (already does); Web Silo-Server/silo-server#4502
The Show Next Up setting offers "At end" and "N seconds before end", but on an episode with a credits marker, both the phone and the TV opened Up Next when the credits started, whatever was chosen (#910). The TV player never read the setting at all. The Apple apps and Roku open Up Next from the chosen number of seconds before the end of the file.
Both Android players now open Up Next when playback crosses the chosen number of seconds before the end of the file, and for "At end" only when playback ends.
Approach
NextUpPrompt.crossesPromptPoint(shared) decides the moment: forward playback crossingplayback.next_up_prompt_secondsbefore the file's duration. A resume or seek past that point waits for the end, so reopening an episode near its end does not throw up the card at once. The phone and TV view models both use it.#927 (credits followed by a preview open the end screen instead of Skip Credits) came from opening Up Next at the credits start, so it is probably fixed too. It has not been re-tested on that fixture, so it stays open.
Validation
./gradlew testDebugUnitTeston this branch: shared 2,510, android-shared 2,312 and Android TV 1,407 tests pass. On the phone module, 1,011 tests ran and threeFormattersTestcases failed; they compare decimal output ("1.0") under the build machine's locale and touch nothing in this change.:androidApp:assembleDebugand:androidTvApp:assembleDebugbuild.lintDebugfor all three modules,lintVitalReleasefor both apps) passes with no new findings, run on the stacked Off branch that contains this change.Evidence
No screen changes: Up Next looks the same and opens at a different time. How it was checked, on this branch:
Risks
Viewers who relied on Up Next opening at the credits start now see it at their Show Next Up time (30 seconds before the end by default).
Checklist
AI Disclosure