Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: Discussion #4443
Validation tasks: changes #1252 C9 (Next Up timing on web; the case is not run yet); changes #1149 C1 (the credits-marker Up next card is removed; Skip Credits itself is unchanged)
Other clients: Apple N/A (already times Next Up from the end of the file); Android Silo-Server/silo-android#994; Roku N/A (already times Next Up from the end of the file)
On the web, Next Up ignored the viewer's Show Next Up choice. The post-roll Next Up screen always opened 30 seconds before the end, and a separate 10-second "Up next" card also popped up when the credits marker started (or the preview marker, with "Start next at preview" on). The native apps open Next Up only from
playback.next_up_prompt_secondsbefore the end of the file, and Discussion #4443 asked for the same timing everywhere.The web player now opens Next Up at the viewer's chosen time before the end of the file, Settings → Playback gets the same Show Next Up picker as the native apps, and the credits-marker card is gone.
Approach
playback.next_up_prompt_secondsof the file's end; 0 ("At end") opens it only when playback ends. Until the setting loads, the player opens nothing early. The existing exclusions (trailers, Watch Together members, and so on) still apply.NextEpisodeOverlay,useNextEpisode) is removed. Skip Credits stays, and skipping credits that run to the end of the file reaches Next Up through the normal end-of-playback path.playback.auto_play_next_preview, which no player reads any more. The server key stays, so nothing else changes.docs/markers-api.mdand a comment ininternal/markersno longer say players open Up Next at the credits start..silo-translationspoints at a local build of that branch until it has a release; this pull request needs a re-sync with--versionbefore merge.Validation
pnpm run lint,format:check,build,budget:checkandmake test-webpass. The new tests cover the window edge, "At end", playback that has not started and an unknown duration. Waiting for the setting to load is not unit-tested.verify-settings-bindings-all,verify-local-paths,verify-size-ratchetpass.Evidence
Evidence: https://evidence.siloserver.org/r/silo-server/pr-4502/
Settings → Playback, desktop and 390 px wide, before (main) and after (this branch), same profile.
Risks
.silo-translationsnames a local build (version=local-…); it must be re-synced before merge.Checklist
AI Disclosure
Note
Time Next Up prompt from the end of the file, not credits markers
NextEpisodeOverlay,useNextEpisodepath in VideoPlayer.tsx) with a newisInNextUpPromptWindowcheck in nextUpPrompt.ts that fires when playback is within the configured lead time of the file's end.PLAYBACK_NEXT_UP_PROMPT_SECONDSsetting, editable in Playback settings via a seconds select (0/10/30/60/120) in NextUpPromptSetting.tsx. The countdown screen (PlayingNextScreen.tsx) now waits for the setting to load before starting.auto-play-next-previewsetting and its props, query, and marker utility across the player, watch-page builders, and settings pages.MEDIA_ENDED_EVENTfallback, and the prompt is deferred when the active item has a later part (not only for shuffled playback). The next control does nothing during room playback, where the next reference is unavailable.Macroscope summarized 015af63.