Skip to content

ci(release): sign releases with a GitHub artifact attestation - #8

Merged
Quick104 merged 4 commits into
mainfrom
ci/sign-releases
Nov 13, 2026
Merged

Quick104 merged 4 commits into
mainfrom
ci/sign-releases

Conversation

@Quick104

@Quick104 Quick104 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

Releases of this plugin are not signed. Silo servers verify a Sigstore bundle when the catalog lists one, and the approved community catalog accepts a signature made by a workflow in this repository run from the release tag. The plugin cannot use the shared Silo release workflow because it builds with make dist, a prepared Tailscale module, and reproducible ZIP archives.

The workflow_dispatch path also creates and pushes the tag inside the job. A run started that way has refs/heads/main as its OIDC ref, so a signature from it would not match the tag and the catalog would refuse the release.

Related issue: N/A (maintainer-directed)

Approach

release.yml now runs only on a pushed v* tag and has four jobs, with top-level permissions: {}:

  • build (contents: read): checks that the tag equals manifest.json version, runs make dist and the existing asset preparation unchanged, and returns checksums.txt as a job output. Go caching is off so a signed build never uses cache entries other runs wrote.
  • attest (id-token: write, attestations: write): checks nothing out, downloads nothing, and runs no repository code. It checks the subject list and attests it with actions/attest-build-provenance (v4.2.2, the shared workflow's pin) using subject-checksums, then returns the bundle as a job output.
  • release (contents: write): downloads the assets, checks them against the build job's checksums, writes plugin.sigstore.json, and runs gh attestation verify on every asset with this workflow's identity at the tag, --source-ref refs/tags/<tag> and --deny-self-hosted-runners. It then publishes with the existing release action and generated notes.
  • dispatch (no permissions): notifies the catalog as before. It is its own job so it can be rerun alone.

The subjects are the raw binaries and the ZIP archives, which is exactly the list in checksums.txt. The catalog needs only the binaries, but the archives are published assets that people can download, and attesting them costs nothing and lets anyone verify any download with one command. The contents and format of checksums.txt are unchanged.

The development guide gains a Releases section covering how to cut a release and how to verify a download. The README's manual install step points to it.

Validation

  • actionlint passes on both workflows.
  • Ran make dist VERSION=0.2.2 locally and ran the extracted workflow steps against its output. The tag check accepted v0.2.2 and refused v0.2.3, a workflow_dispatch run on main, and a branch push. The new checksums.txt is byte-identical to the old workflow's. The subject check refused an extra line. The release check passed on the real files and refused a tampered binary and an extra file. With gh stubbed out, the verify step built the expected arguments for all six assets.
  • Ran the same gh attestation verify flag set against a release signed by the shared Silo workflow. It passed with that workflow's identity and failed with a different one.
  • Not run: the attestation itself and verification of a bundle signed by this workflow. Both need a tag push in this repository.

Risks

The next release must be cut by pushing a tag, on a commit that is on main, whose version matches manifest.json. The approved community catalog accepts this workflow as the plugin's signer only once the plugin's approval entry names it (signer_workflow). There is no manual dispatch any more. The first signed release is the real test of the attest and verify steps. If verification fails, nothing is published. Because the workflow runs from the tagged commit, a fix to it ships with the next version and tag.

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.

AI Disclosure

  • Harness: Claude Code (in T3 Code)
  • Tool(s): Claude Code
  • Model(s): claude-opus-5-5, claude-fable-5-2
  • Involvement: Fully AI-generated, human verification pending
  • Adversarial review: n/a; no independent review was run on this change.

🤖 Generated with Claude Code

Tag releases now attest the raw binaries and ZIP archives in a signing job that runs no repository code, publish the bundle as plugin.sigstore.json, and verify every asset against it before publishing. The workflow_dispatch path is gone because its signature would carry refs/heads/main, and the tag must now equal manifest.json version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Quick104 and others added 3 commits November 13, 2026 17:10
The approved community catalog lists a release signed by this workflow
only when its commit is on the default branch. Checking that before the
build stops a release the catalog would refuse from being published.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@Quick104
Quick104 merged commit 5cff541 into main Nov 13, 2026
2 checks passed
@Quick104 Quick104 mentioned this pull request Nov 13, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant