Skip to content

feat(approval): accept the Tailscale plugin's own release workflow as its signer - #20

Merged
Quick104 merged 1 commit into
mainfrom
approve/tailscale-signer-workflow
Nov 13, 2026
Merged

Quick104 merged 1 commit into
mainfrom
approve/tailscale-signer-workflow

Conversation

@Quick104

@Quick104 Quick104 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Related issue: N/A (maintainer-directed; follows #19 and Silo-Community/silo-plugin-tailscale#8)

The Tailscale plugin cannot use the shared Silo release workflow: it builds with make dist, a prepared module file, and reproducible ZIP archives. Silo-Community/silo-plugin-tailscale#8 makes its own release.yml sign releases. Since #19 this catalog accepts only the shared workflow as a signer unless a plugin's approval names another, so the plugin's first signed release would be refused.

Approach

Adds "signer_workflow": "release.yml" to the Tailscale plugin's entry in approved-plugins.json. The catalog then accepts a release of that plugin only when it is signed by release.yml in Silo-Community/silo-plugin-tailscale, run from the release tag, for a commit on the default branch.

What was reviewed against APPROVAL_POLICY.md's "Release signing" section, on the pull request's head:

  • release.yml runs only on a pushed v* tag, refuses a tag that does not match manifest.json or whose commit is not on main, and uses GitHub-hosted runners.
  • The build job holds no signing permission. The signing job attests the checksums the build job returns, downloads nothing, and runs no repository code. The release job checks the downloaded files against those checksums and against the bundle before publishing.
  • Not met yet: the plugin repository's main has no branch protection. The policy asks for it before this field is set.

Validation

  • go run ./cmd/check-catalog: pass. go test ./...: pass.
  • update-catalog for the listed Tailscale release is still a no-op against a copy of the catalog.
  • Not run: a signed Tailscale release. None exists yet; the first one exercises this signer and the default-branch check for the first time.

Risks

Checklist

  • I read and can explain the complete diff.
  • This pull request addresses one concern.

AI Disclosure

🤖 Generated with Claude Code

… its signer

The Tailscale plugin builds with its own reproducible build and cannot use
the shared release workflow. Its release.yml now signs releases from the
tag, so its approval names that workflow as the signer.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@Quick104
Quick104 merged commit 9e8e87e into main Nov 13, 2026
1 check passed
@Quick104
Quick104 deleted the approve/tailscale-signer-workflow branch November 13, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant