Repository navigation
feat(approval): accept the Tailscale plugin's own release workflow as its signer - #20
Merged
Merged
Conversation
… its signer The Tailscale plugin builds with its own reproducible build and cannot use the shared release workflow. Its release.yml now signs releases from the tag, so its approval names that workflow as the signer. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related issue: N/A (maintainer-directed; follows #19 and Silo-Community/silo-plugin-tailscale#8)
The Tailscale plugin cannot use the shared Silo release workflow: it builds with
make dist, a prepared module file, and reproducible ZIP archives. Silo-Community/silo-plugin-tailscale#8 makes its ownrelease.ymlsign releases. Since #19 this catalog accepts only the shared workflow as a signer unless a plugin's approval names another, so the plugin's first signed release would be refused.Approach
Adds
"signer_workflow": "release.yml"to the Tailscale plugin's entry inapproved-plugins.json. The catalog then accepts a release of that plugin only when it is signed byrelease.ymlinSilo-Community/silo-plugin-tailscale, run from the release tag, for a commit on the default branch.What was reviewed against APPROVAL_POLICY.md's "Release signing" section, on the pull request's head:
release.ymlruns only on a pushedv*tag, refuses a tag that does not matchmanifest.jsonor whose commit is not onmain, and uses GitHub-hosted runners.mainhas no branch protection. The policy asks for it before this field is set.Validation
go run ./cmd/check-catalog: pass.go test ./...: pass.update-catalogfor the listed Tailscale release is still a no-op against a copy of the catalog.Risks
main. The plugin repository'smainis still unprotected; the maintainer chose to merge this with that gap open.Checklist
AI Disclosure
🤖 Generated with Claude Code