Skip to content

chore(quality): establish Rust baseline - #1036

Open
aaf2tbz wants to merge 3 commits into
mainfrom
aaf2tbz/issue-919-rust-quality-baseline
Open

chore(quality): establish Rust baseline#1036
aaf2tbz wants to merge 3 commits into
mainfrom
aaf2tbz/issue-919-rust-quality-baseline

Conversation

@aaf2tbz

@aaf2tbz aaf2tbz commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Establish the Rust quality baseline for the daemon workspace and resolve the two daemon test regressions that prevented the baseline from being a true green gate. This is PR 3 of #919; it does not close the issue.

Changes

  • Added a pinned Rust 1.96.1 toolchain with rustfmt and Clippy components.
  • Added shared workspace lint policy and opted every Rust workspace crate into it.
  • Added root rust:fmt, rust:clippy, rust:check, rust:test, rust:quality, and rust:deny commands.
  • Added cargo-deny policy, workspace license inheritance, and the fixable anyhow security update.
  • Resolved baseline diagnostics and isolated SQLite test databases so the core test suite can run in parallel.
  • Fixed canonical transcript staging-path validation on macOS, where /tmp resolves to /private/tmp.
  • Made AGENT.yaml take precedence over lowercase agent.yaml, including on case-insensitive filesystems.

Type

  • feat — new user-facing feature
  • fix — daemon test regressions
  • refactor
  • chore — build, deps, config, docs
  • perf
  • test — regression coverage

Packages affected

  • Other: Rust daemon workspace quality tooling, dependency policy, and daemon routes

Screenshots

N/A — no UI behavior change.

PR Readiness (MANDATORY)

  • Spec alignment validated (INDEX.md + dependencies.yaml)
  • Agent scoping verified on all new/changed data queries
  • Input/config validation and bounds checks added
  • Error handling and fallback paths tested (no silent swallow)
  • Security checks applied to admin/mutation endpoints
  • Docs updated for API/spec/status changes
  • Regression tests added for each bug fix
  • Lint/typecheck/tests pass locally

Migration Notes (if applicable)

No schema or migration semantics changed. The lockfile update is backward-compatible; the two cargo-deny advisory exceptions remain documented upstream migrations with no safe update.

  • Migration is idempotent
  • Daemon Rust parity reviewed or explicitly N/A
  • Rollback / compatibility note included

Testing

  • bun run rust:fmt passes
  • bun run rust:clippy passes with warnings denied
  • bun run rust:check passes
  • bun run rust:test passes: all workspace suites, including 199 daemon tests
  • bun run rust:deny passes
  • Focused regression tests pass:
    • prompt_submit_writes_transcript_audit_and_live_snapshot
    • finds_fallback_config_files
  • git diff --check passes
  • N/A — no running-daemon behavior changed

AI disclosure

  • No AI tools were used in this PR
  • AI tools were used

Notes

The former 403 transcript failure was a real canonical-path mismatch on macOS; the fallback config failure was a real filename-precedence mismatch on case-insensitive filesystems. Both are fixed in this PR. The follow-up quality-gates PR makes these local Rust commands mandatory in CI alongside supply-chain and governance protections.

@aaf2tbz aaf2tbz added priority: P1 High priority bucket: ops-hardening Operational reliability, cost, and safety hardening labels Jul 28, 2026
@aaf2tbz
aaf2tbz marked this pull request as ready for review July 28, 2026 04:37
@aaf2tbz aaf2tbz self-assigned this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bucket: ops-hardening Operational reliability, cost, and safety hardening priority: P1 High priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant