chore(quality): add cross-platform enforcement gates - #1037
Open
aaf2tbz wants to merge 2 commits into
Open
Conversation
Add Linux/macOS quality workflow, local hooks, ownership, package/dead-code baselines, and remove checklist-exception bypasses. Document the #969 prerequisite for hard TypeScript enforcement and branch protection.
aaf2tbz
marked this pull request as ready for review
July 28, 2026 04:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the enforcement and governance layer for #919: one Linux/macOS quality workflow spanning TypeScript/JavaScript and Rust, local prevention hooks, ownership, package/dead-code baselines, and non-bypassable PR guards. This is PR 4 of the quality-hardening sequence and closes the issue when merged.
Changes
hooks:install.checklist-exceptionbypass from readiness, bugfix-regression, and migration guards.Type
feat— new user-facing feature (bumps minor)fix— bug fixrefactor— restructure without behavior changechore— build, deps, config, docsperf— performance improvementtest— test coveragePackages affected
@signet/core@signet/daemon@signet/cli/ dashboard@signet/sdk@signet/connector-*@signet/webpredictorScreenshots
N/A — no UI behavior change.
PR Readiness (MANDATORY)
INDEX.md+dependencies.yaml)Migration Notes (if applicable)
No schema or migration semantics changed.
Testing
bun testpasses (run on freshmain: 1,043 pass, 46 skip, 209 existing failures; details below)bun run typecheckpasses (remains advisory until #969)bun test scripts/quality-gates-workflow.test.tspassesbun test scripts/check-publish-manifests.test.tspassesbun run check:publish-manifestspasses@signet/coreand@signet/connector-basebuilds plus focused connector-base tests passgit diff --checkvalidatedAI disclosure
Notes
This was created from a clean SSD worktree at the latest
origin/main. Dependencies were installed withPUPPETEER_SKIP_DOWNLOAD=1, so no Puppeteer browser binary was downloaded.bun testcurrently exposes baseline failures in route parity, a stale web content index, and workspace-package resolution; the new workflow makes those failures visible rather than masking them. Knip reports 372 unused files / 110 unused exported types, and package API lint reports existing publish-output and export-order findings, so both are advisory baselines for now.The Rust and Biome enforcement commands rely on the preceding baseline PRs #1034 and #1036. After those land and #969 clears the TypeScript backlog, repository administrators must make the workflow checks required, require review, and block direct pushes to
mainin branch protection.Closes #919