Skip to content

fix: display slideshow arrows only if generic images exist #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luechinger wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: display slideshow arrows only if generic images exist #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion snippets/product-media-gallery-content.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@
assign slideshow_class = ''

if media_presentation == 'carousel'
assign render_slideshow_arrows = true
assign pdp_variant_images = selected_product.images | where: 'attached_to_variant?', true | map: 'src'
assign pdp_generic_media_size = selected_product.media.size | minus: pdp_variant_images.size
if pdp_generic_media_size > 0
assign render_slideshow_arrows = true
endif
endif
endif

Expand Down