fix: display slideshow arrows only if generic images exist#68
Open
luechinger wants to merge 1 commit intoShopify:mainfrom
Open
fix: display slideshow arrows only if generic images exist#68luechinger wants to merge 1 commit intoShopify:mainfrom
luechinger wants to merge 1 commit intoShopify:mainfrom
Conversation
Context: If color swatches are enabled and multiple product variants (with their variant image) exist, the current version of Horizon will always display slideshow arrows – even if no "generic" images are present. In this case, clicking the arrow will have no effect, thus confusing the user. Fix: Added a check for generic images which are not attached to a variant. Hide slideshow arrows if not the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
If color swatches are enabled and multiple product variants (with their variant image) exist, the current version of Horizon will always display slideshow arrows – even if no "generic" images are present. In this case, clicking the arrow will have no effect, thus confusing the user.
Fix:
Added a check for generic images which are not attached to a variant. Hide slideshow arrows if not the case.