Skip to content

Add custom board definition#513

Merged
AwesomeTornado merged 3 commits into
developfrom
feature/add-custom-board
Jun 10, 2026
Merged

Add custom board definition#513
AwesomeTornado merged 3 commits into
developfrom
feature/add-custom-board

Conversation

@AwesomeTornado

Copy link
Copy Markdown
Member

Closes #10
@elsevers

Notes

Docs.amdc.dev should be updated to reflect the new board files. The current docs are ok, but could be better.

This board file is just a reskin of the previous one.

Self-Review

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

Reviewer Instructions

Reviewers, please copy and paste a suitable review checklist into your review and answer all questions.

Appendix

This section should be the same for all PRs. Do not edit this section when creating a PR.

Review Checklists

Checklists maintained by the eLev lab for research repositories include:

Standard checklist

1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? **Yes or No**
2. Are all files named according to the appropriate [naming convention](https://github.com/Severson-Group/research-repo-template?tab=readme-ov-file#file-naming), i.e., dash-case, camelCase, snake case? **Yes or No**
3. Do all Markdown files follow the [CONTRIBUTING article template](https://github.com/Severson-Group/.github/blob/main/CONTRIBUTING.md#markdown-documentation-template)? **Yes or No**
4. Do all links work in the material that the PR is adding? **Yes or No**
5. Is the PR configured to close the correct issue(s)? **Yes or No**
6. Did the PR fully address the `Approach` section of the issue(s) it is closing? **Yes or No**

Please work on addressing any **No** items.

@AwesomeTornado AwesomeTornado requested a review from elsevers as a code owner June 4, 2026 04:06
@AwesomeTornado AwesomeTornado linked an issue Jun 4, 2026 that may be closed by this pull request

@elsevers elsevers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's update the earlier hardware revisions too

@elsevers elsevers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Are all images < 40 kB and other files < 300 kB (if not, please carefully assess whether it is worth committing them)? Yes
  2. Are all files named according to the appropriate naming convention, i.e., dash-case, camelCase, snake case? Yes
  3. Do all Markdown files follow the CONTRIBUTING article template? Yes
  4. Do all links work in the material that the PR is adding? Yes
  5. Is the PR configured to close the correct issue(s)? Yes
  6. Did the PR fully address the Approach section of the issue(s) it is closing? Yes

@AwesomeTornado AwesomeTornado merged commit 361413e into develop Jun 10, 2026
1 check passed
@AwesomeTornado AwesomeTornado deleted the feature/add-custom-board branch June 10, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create AMDC board definition file for Vivado

2 participants