Skip to content

Fix ByteListTag reading its own type and single-element lists #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PMK744 merged 2 commits into from
Oct 17, 2026
Merged

Fix ByteListTag reading its own type and single-element lists #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f209003
fix(nbt): create correct array instead of empty one
tutinoko2048 Oct 17, 2026
bb807b2
fix(nbt): use `ByteListTag` for comparing `ByteListTag`
tutinoko2048 Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/nbt/src/types/byte-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ class ByteListTag extends Array<number> implements BaseTag {
* @param name The name of the tag, defaults to null.
*/
public constructor(elements: Array<number>, name?: string | null) {
super(...elements);
// Push the elements, so a single element is not treated as a length.
super();
this.push(...elements);
this.name = name ?? null;
}

Expand Down Expand Up @@ -46,10 +48,10 @@ class ByteListTag extends Array<number> implements BaseTag {
const type: TagType = stream.readInt8();

// Verify that the tag type matches the expected type.
if (type !== TagType.Byte) {
if (type !== TagType.ByteList) {
// Throw an error if the type does not match.
throw new Error(
`Expected tag type to be ${TagType[TagType.Byte]}, received ${TagType[type] ?? type}.`
`Expected tag type to be ${TagType[TagType.ByteList]}, received ${TagType[type] ?? type}.`
);
}
}
Expand Down
Loading