Skip to content

subtitleedit4: Add version 4.0.16#2961

Merged
z-Fng merged 1 commit into
masterfrom
add-subtitleedit4
Jul 14, 2026
Merged

subtitleedit4: Add version 4.0.16#2961
z-Fng merged 1 commit into
masterfrom
add-subtitleedit4

Conversation

@z-Fng

@z-Fng z-Fng commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Closes #2960
Relates to ScoopInstaller/Extras#18263

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

subtitleedit4

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

@z-Fng
z-Fng merged commit 12c8187 into master Jul 14, 2026
5 checks passed
@z-Fng
z-Fng deleted the add-subtitleedit4 branch July 14, 2026 18:41
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Summary by CodeRabbit

  • New Features
    • Added support for installing Subtitle Edit 4.0.16 on Windows.
    • Added a Start Menu shortcut for launching Subtitle Edit.
    • Preserves application settings across installations.

Walkthrough

Changes

Subtitle Edit 4 packaging

Layer / File(s) Summary
Package manifest and runtime configuration
bucket/subtitleedit4.json
Adds the Subtitle Edit 4 version 4.0.16 manifest with download metadata, SHA256 validation, Settings.xml initialization and persistence, the SubtitleEdit.exe entry point, and a start-menu shortcut.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly identifies the manifest and version being added.
Description check ✅ Passed The description follows the template well and includes the issue references and checklist items.
Linked Issues check ✅ Passed The new manifest matches the request for a separate Subtitle Edit 4 package at version 4.0.16 with standard installation behavior.
Out of Scope Changes check ✅ Passed The changes are limited to the requested manifest addition and do not introduce unrelated scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
bucket/subtitleedit4.json (1)

16-16: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add 4.x update metadata.

Without checkver and autoupdate, this manifest remains permanently pinned to 4.0.16. The corresponding extras/subtitleedit manifest already defines GitHub version detection and SE$cleanVersion.zip updates; mirror that configuration here for future Subtitle Edit 4 releases. (raw.githubusercontent.com)


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb11de38-6684-4a10-b196-cf2e64e027cc

📥 Commits

Reviewing files that changed from the base of the PR and between 4e57e6c and 37c918a.

📒 Files selected for processing (1)
  • bucket/subtitleedit4.json

Comment thread bucket/subtitleedit4.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: subtitleedit4

1 participant