subtitleedit: Update to version 5.0.0, add arm64 version#18263
Conversation
📝 WalkthroughWalkthroughThis pull request updates the SubtitleEdit Scoop manifest from version 4.0.16 to 5.0.0, adds architecture-specific download URLs and hashes, changes persisted settings from Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
|
All changes look good. Wait for review from human collaborators. subtitleedit
|
That would be perfect! I've already copied it over to the Versions bucket (ScoopInstaller/Versions#2961). If ScoopInstaller/Scoop#6370 gets merged and released, we won't have to worry about this issue anymore in the future. |
|
/verify |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/subtitleedit.json (1)
29-38: 🎯 Functional Correctness | 🔵 TrivialValidate autoupdate and installation for both architectures.
Scoop supports architecture-specific
64bitandarm64manifest fields, and Subtitle Edit v5 publishes matching Windows x64 and ARM64 archives. (github.com).\bin\checkver.ps1 -App subtitleedit -f .\bin\formatjson.ps1 -App subtitleedit scoop install bucket/subtitleedit.json -a 64bit scoop install bucket/subtitleedit.json -a arm64Also verify the manifest uses CRLF line endings. As per path instructions, test autoupdate, formatting, installation, and line endings locally.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/subtitleedit.json` around lines 29 - 38, Validate the subtitleedit manifest’s autoupdate configuration for both architecture entries, ensuring the 64bit and arm64 URLs resolve to the matching Subtitle Edit archives. Run checkver, formatjson, and installation tests for both architectures, and verify the manifest uses CRLF line endings.Sources: Path instructions, MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@bucket/subtitleedit.json`:
- Around line 29-38: Validate the subtitleedit manifest’s autoupdate
configuration for both architecture entries, ensuring the 64bit and arm64 URLs
resolve to the matching Subtitle Edit archives. Run checkver, formatjson, and
installation tests for both architectures, and verify the manifest uses CRLF
line endings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 814defa3-50a3-4a0b-b83a-4e1d3719dcde
📒 Files selected for processing (1)
bucket/subtitleedit.json
|
All changes look good. Wait for review from human collaborators. subtitleedit
|
Update to version 5.0.0, add arm64 version, update settings handling.
As from SE 5.0.0 release notes:
Wonder if manifest for SE 4.x should be placed into
Versionsbucket before merging update.<manifest-name[@version]|chore>: <general summary of the pull request>