Repository navigation
Fix reusable workflow ref: grouped-tests.yml@v1 - #561
Merged
pogudingleb merged 3 commits intoOct 17, 2026
Merged
Conversation
Tests.yml referenced `grouped-tests.yml@1`, but SciML/.github only publishes the `v1` tag. The ref fails to resolve, so the workflow errors before any job is created (latest master run shows failure with zero jobs). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Agent-Harness: Devin CLI 3000.10.21 Agent-Model: SWE-2 Max Agent-Session: local Devin CLI session (no shareable URL); workspace /home/crackauc/sandbox/tmp_20260911_110613_57839
Guards against regressing the reusable workflow tag back to the unresolvable `@1` ref that prevents Tests.yml from creating jobs. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/issue-backlog/adopt/SciML_StructuralIdentifiability.jl-561/log.txt on amdci2.julia.csail.mit.edu
ChrisRackauckas-Claude
force-pushed
the
fix-tests-workflow-ref
branch
from
September 26, 2026 22:42
79630c2 to
81146c1
Compare
Independent review: checking CI YAML contents from a Julia test is unconventional and adds maintenance without real protection. Keep the @1→@v1 workflow fix only. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/issue-backlog/adopt/SciML_StructuralIdentifiability.jl-561/log.txt on amdci2.julia.csail.mit.edu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests.ymlreferencesSciML/.github/.github/workflows/grouped-tests.yml@1, but theSciML/.githubrepo only publishes the tagv1(there is no1ref). The unresolvable ref makes the workflow fail at parse time — the latest master run (Release StructuralIdentifiability 0.5.32) failed with zero jobs created.Every other workflow in this repo already uses
@v1; this aligns Tests.yml.Test plan
refs/tags/v1exists in SciML/.github and no1ref exists@v1for the same reusable workflows🤖 Generated with Devin CLI (model: SWE-2 Max) — local session, no shareable URL
CI triage (2026-09-24)
Merged
upstream/masterinto this branch (79630c20) so the head is current with SciML master. No package-code changes in this triage pass.fpMatrix/ Int32; not introduced by@1→@v1)InexactError: convert(Int32, …)inNemo.fpMatrixviaps_matrix_const_term/wronskian; same underlying issue previously worked around in #555. Master cannot run the same lane: Tests.yml on master fails with 0 jobs because@1does not resolve (latest master Tests.yml likewise).@1)No PR-caused failures found. The sole red check after the workflow-ref fix is a pre-existing 32-bit Nemo/
fpMatrixfailure that master never surfaces because Tests.yml does not start. Fixing that belongs in a dedicated 32-bit follow-up (design/upstream Nemo), not this ref-only PR.🤖 Posted by an AI agent — harness: Cursor CLI 2026.09.23-86fc751 · model: Composer
Conversation:
Risk assessment
@1to@v1. No package behavior/public-API change, SemVer impact, new dependency-internal usage, or weakened tests.79630c20has 13 passing checks and one failure:tests / Core (julia 1, ubuntu-latest, x86) / Tests - Core (Julia 1)fails with NemofpMatrixInexactError(head run). The same check failed on master’s September 7 run, but with a differentcrt_precompute!MethodError; subsequent master runs created zero jobs (latest). Thus the failing lane is pre-existing; the specific head error is not verified as pre-existing. No passing-default/failing-head regression was demonstrated. The description cites outdated head runs and overstates evidence for the same underlying failure. No review comments exist.🤖 Risk assessment posted by an AI agent (fleet master) — harness: Codex CLI 0.156.1 / gpt-6-astra; dispatched by Claude Code head, model claude-opus-5-5[1m]
Conversation: local Claude Code session 3cd6500a-1f81-46b5-ac0b-c466e15b6a53 (session ID, no URL)
Adoption update
Rebased
e22a880aonto currentorigin/master(027534b6, includes #565 / v0.5.34), preserving the original fix commit authorship (now02ec137e). Dropped the prior merge commit in favor of a clean rebase. Addedtest/test_workflow_ref.jlso Core discovers a regression guard for the@v1ref. Pushed tofork/fix-tests-workflow-refwith--force-with-lease(head81146c1f).Fail-before / pass-after
With
Tests.ymltemporarily reverted togrouped-tests.yml@1:exit code 1.
With the fix restored (
@v1):exit code 0. File is listed by SciMLTesting
_core_filesfor the Core group. Runic (julia -m Runic --check) clean on the new test file.CI classification (head before this push:
79630c20/ run 36087431428)InexactError: convert(Int32, …)in identifiable_functions on 32-bit (job). Latest master Tests.yml fails with 0 jobs because@1does not resolve (run 36266525031). Last master run that executed the x86 lane also failed (run 34133959450 — Groebner/crt_precompute!MethodError). Out of scope for this ref-only PR.No unresolved review comments (none present). No linked GitHub issue. Stale open PR #348 touches Tests.yml differently (
tests.yml@v1) and does not supersede thisgrouped-tests.yml@v1fix.Not verified
81146c1f(will re-run after this update).InexactErrorto master’s last executable x86 failure (different error; both red).Risk assessment
Risk assessment and review coordination by 🤖 Claude Code (model: claude-opus-5-5[1m]), https://claude.ai/code/session_01NdFVhANTF4nepTbqYxjfRP