Repository navigation
Wire observation_field test into Core - #567
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
PR SciML#543 added test/bodies/observation_field.jl but omitted the top-level wrapper SciMLTesting discovers under GROUP=Core, so the test never ran. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.10.01-14929f9 Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/si-obsfield/log.txt on amdci2
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #543 added
test/bodies/observation_field.jlbut never added the top-level@safetestsetwrapper that SciMLTesting's folder-discovery mode runs underGROUP=Core(test/bodies/is explicitly non-discovered). This addstest/observation_field.jlin the same pattern as the other Core siblings so the existing body is actually executed.Verification
Isolated body (after wiring wrapper pattern / proper test deps):
Tail:
Core group:
Tail (includes newly discovered file; full suite green):
Runic
--inplaceandtyposontest/observation_field.jl: clean.Not verified
QA / ModelingToolkitSIExt groups; package docs build; GitHub CI (master workflow ref still broken pending #561). Did not touch
.github/.Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
@safetestsetwrapper including an already-merged body; no production code changes.GROUP=CorePkg.test()passed withCore/observation_field.jlin the summary.Harness: Cursor Agent CLI 2026.10.01-14929f9; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/si-obsfield/log.txt
Made with Cursor