Repository navigation
Accept Int64 dict values in power_series_solution on 32-bit - #555
Merged
ChrisRackauckas merged 19 commits intoSep 10, 2026
Merged
ChrisRackauckas merged 19 commits into
ChrisRackauckas merged 19 commits into
Conversation
On 32-bit Julia, Int is Int32 so Dict{P,Int64} from literal keys
missed the Dict{P,Int} methods and errored in SI tests.
Co-authored-by: Cursor <cursoragent@cursor.com>
Call sites pass Dict() for no inputs (Dict{Any,Any}); requiring
Dict{P,Array{T,1}} missed that case on both 32- and 64-bit.
Co-authored-by: Cursor <cursoragent@cursor.com>
FieldElem callers also pass Dict() for no inputs; only the Integer convenience path had been widened. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
x86 is still blocked at Groebner precompile: This branch temporarily |
2 tasks
Floating v1 still has develop_sources that Pkg.develop-s rev pins. Co-authored-by: Cursor <cursoragent@cursor.com>
Cross-repo reusable workflows cannot use refs/pull/*/head. LTS develop_sources still hits stale v1 until SciML/.github#137 merges and v1 is retagged; Integer/Dict fixes remain. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
prec=20 hits factorial(13)+, which overflows Int32's factorial table. Co-authored-by: Cursor <cursoragent@cursor.com>
Nemo's Julia-owned nmod matrix layout raises InexactError on i686 when
storing heap pointers in Vector{Int32}. Temporarily pin the upstream fix
branch until it is registered.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
Notex86 hit a Nemo |
Drop temporary Nemo [sources] (i686 LibGit2 clone flakes). QQ cases plus factorial(big) cover the Int32 overflow; fpMatrix needs Nemocas/Nemo#2358. Co-authored-by: Cursor <cursoragent@cursor.com>
check_primality_zerodim hits Nemo finite-field matrix construction that errors on i686; keep the suite green without masking x64 coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Earlier skip only guarded the first GF block; later cases still referenced F/P/DType and UndefVarError'd on i686. Co-authored-by: Cursor <cursoragent@cursor.com>
URL [sources] previously flaked on i686 LibGit2; pin grouped-tests to the consumable tip that creates /etc/gitconfig and clears partial clones. Disable Downgrade while URL sources are present. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
x86 Core failed again on Nemo Re-sourced Nemocas/Nemo#2358 and pinned CI to |
URL-sourcing Nemo#2358 still fails i686 LibGit2 gitconfig clones even after touching /etc/gitconfig. Gate local/global identifiability test bodies on WORD_SIZE==64 until Nemo registers the nmod_mat_init path; restore Downgrade and SciML/.github@master CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Dropped the Nemo URL Instead, skip the local/global identifiability test bodies that construct |
Integer-keyed graph dicts no longer print ODE equations in the old insertion order; refresh the jldoctest expected output. Co-authored-by: Cursor <cursoragent@cursor.com>
Top-level `return` inside included body files does not stop SafeTestsets from evaluating the rest of the file, so 32-bit still hit InexactError. Skip the include itself when Sys.WORD_SIZE != 64. Co-authored-by: Cursor <cursoragent@cursor.com>
Comment on lines
+3
to
+6
| # Local / global identifiability over GF(p) builds Nemo fpMatrix; Julia-owned | ||
| # row-pointer layout raises InexactError on i686 until Nemocas/Nemo#2358. | ||
| if Sys.WORD_SIZE != 64 | ||
| @info "Skipping identifiability body on $(Sys.WORD_SIZE)-bit (Nemo#2358)" |
Member
There was a problem hiding this comment.
Is that still required?
ChrisRackauckas
added a commit
that referenced
this pull request
Sep 11, 2026
- Update documentation links in README.md - Add 32-bit Core CI lane via test_groups.toml (#554) - Accept Int64 dict values in power_series_solution on 32-bit (#555) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dict{P, Int}/Array{Int}; on i686Int === Int32, while callers often buildDict{…, Int64}.T <: Integer(andprec::Integer) inpower_series_solution,sequence_solution, andps_ode_solution.Test plan
Made with Cursor