Repository navigation
Align NLStep TRBDF2 parity test estimator - #4077
Merged
ChrisRackauckas merged 1 commit intoAug 2, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Member
Author
|
Hosted CI classification after the first run:
These are clean-base/external-registration blockers, not failures introduced by this test-only commit, so I have not changed the branch in response. The exact relevant group passes locally on current master when developed against clean local SciMLBase 3.40.1, as recorded in the PR body. |
5 tasks done
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
agent/align-nlstep-parity-estimator
branch
from
August 2, 2026 15:32
4300fd7 to
3f80217
Compare
ChrisRackauckas
marked this pull request as ready for review
August 2, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
nlstep = trueTRBDF2 paths withsmooth_est = false2e-4saved-trajectory threshold unchangedCause
The smoothed-estimator change in #3823 lets the full-state
NonlinearSolveAlgpath reuse its W solve. The reduced MTK NLStep problem intentionally cannot provide that full-state solve and falls back to the raw estimator. The parity test therefore compares two different error-estimation strategies rather than only the two nonlinear-solve paths.An exact diagnostic gave a maximum saved-trajectory delta of
3.052191084731426e-4with the default mixed estimators and1.2863503533355747e-4when both paths use the raw estimator. The latter satisfies the existing threshold without weakening it. Smoothed-error behavior remains covered separately bynsa_smooth_est_tests.jl.Local verification
On an untouched current-master checkout at
a7080c6f6d:GROUP=OrdinaryDiffEqNonlinearSolve_ModelingToolkit julia +1.12 --project -e 'using Pkg; Pkg.test()'— fails with0.0003052191084731426 < 0.0002On the rebased branch at
3f802179a8:git diff --checkpasses