Repository navigation
Remove stale root test copies and fix the ModelingToolkit test group - #4637
Merged
ChrisRackauckas merged 2 commits intoOct 3, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
GROUP=ModelingToolkit falls through SciMLTesting run_tests to the empty root core body, so the three CI lanes only pay install/precompile cost. The orphaned root modelingtoolkit/multirate/multithreading copies are strictly stale versus the live sublibrary tests that already run them. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/ode-layout/log.txt on amdci2
The root ModelingToolkit test Project.toml is gone with the orphaned copies, so Dependabot should not keep scanning that directory. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/ode-layout/log.txt on amdci2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GROUP=ModelingToolkitis declared intest/test_groups.tomland CI schedules three lanes for it, buttest/runtests.jlhas no ModelingToolkit body: SciMLTesting'srun_teststreats the unknown group as a fall-through to the rootcore = () -> nothingno-op (confirmed in SciMLTesting 2.13 source, master CI job logs where the test body finishes in ~1.3s after ~14 minutes of install/precompile, and a local SciMLTesting probe). This PR removes that empty[ModelingToolkit]entry so CI stops burning those lanes, and drops the stale Dependabot directory for the deletedtest/modelingtoolkitProject.toml.It also deletes orphaned root copies under
test/modelingtoolkit/,test/multirate/, andtest/multithreading/that are never included from the root runner. Same-named tests already run inOrdinaryDiffEqNonlinearSolve,OrdinaryDiffEqDifferentiation,OrdinaryDiffEqMultirate, andOrdinaryDiffEqExtrapolation. The root copies never ran in any root lane, so their diffs vs the lib copies are not live coverage loss. Precise differences:Rodas5; lib usesRodas5P.≈ atol=1e-3checks where lib uses5e-3, and root ran TRBDF2 with defaultsmooth_estwhere lib deliberately usessmooth_est=false(Align NLStep TRBDF2 parity test estimator #4077). Lib is otherwise stricter: two@test_broken→@test, and the FBDF order tolerance goes from0.3/0.35to0.05.2^orderwithin 15%; lib usestest_convergenceatol=0.3and adds exactnf/nf2counts and a dense-output testset.Verification
gh run view 36096837419 --job 107957121978): afterGROUP=ModelingToolkitand full precompile (~822s), the test phase is1.257923 secondsthenOrdinaryDiffEq tests passedwith no safetestset/include of any modelingtoolkit file.git log --followfor each deleted root file vs its sublibrary counterpart (precise diffs above).typosclean on touched files. No.jlcontent edited (only deletions / Dependabot YAML), so Runic not applicable.Not verified
GROUP=ModelingToolkit julia --project -e 'using Pkg; Pkg.test()'was not re-run end-to-end (would only reconfirm the empty core after a long resolve/precompile); dispatch path and master CI log were used instead.Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
Harness: Cursor Agent CLI 2026.09.26-dd393fe; model: auto; transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/ode-layout/log.txt on amdci2