Close the unterminated @testset in ode_initdt_tests.jl - #4013
Merged
ChrisRackauckas merged 1 commit intoJul 25, 2026
Merged
Conversation
The `@testset "DAE reversed tspan automatic initdt (SciML#908)"` block added in SciML#4001 was never closed, so `ode_initdt_tests.jl` failed to parse: the file's final `end` closed the `for` loop and the parser hit EOF still expecting the testset's `end`. This took out every job that loads the file — InterfaceI on lts/1/pre, the Downgrade InterfaceI lane, and the Runic format check. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
The failure
test/InterfaceI/ode_initdt_tests.jldoes not parse on master:The
@testset "DAE reversed tspan automatic initdt (#908)"block added in #4001was never closed. The file's last
endcloses theforloop inside it, so theparser reaches EOF still expecting the testset's
end.Blast radius
One missing
end, five red jobs on master:tests / InterfaceI (julia lts)Initdt Testserrored, group failedtests / InterfaceI (julia 1)tests / InterfaceI (julia pre)Downgrade / Downgrade Tests - InterfaceIformat-check / Runic[954/1017] test/InterfaceI/ode_initdt_tests.jl ✖(Runic cannot format a file that will not parse)Because the file never parsed, every assertion in the #908 testset has been
dead since #4001 merged — the
integ.dt < 0regression check that PR waswritten to add has never actually executed.
The fix
Add the missing
end.Verification
Ran locally on Julia 1.10 (lts), from a clean checkout of this branch:
29 passing assertions where master got 15 passed + 1 error — the 14 newly-live
assertions in the #908 testset all pass, so #4001's fix is sound; only its test
was unreachable.
Runic is clean on the file:
Relation to other PRs
#4012 bundles this fix together with two unrelated changes. This PR is the
parse fix on its own so it can land and unblock InterfaceI/Downgrade/format-check
independently.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TPHRh64BLfoXSzQ3AxKNwC