Downgrade: Core extras, initdt parse fix, AMF Krylov ref (no floors) - #4012
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
1. OrdinaryDiffEqCore: add SparseArrays to [extras] (already weakdep + test target) so Pkg.test does not abort under Downgrade. 2. InterfaceI ode_initdt_tests: close the missing @testset end on the DAE reversed-tspan block (SciML#4001/SciML#4000 merge ParseError). 3. OrdinaryDiffEqAMF tests: use ROS34PW1a(linsolve=KrylovJL()) for dense reference solves with operator jac_prototype (SciMLOperators WOperator convert MethodError on AddedOperator/tensor-product graphs until SciMLOperators#411 / v1.24.5). Adjoint FD relerr tol 0.01 → 0.015. No version floor changes in this commit. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Conservative floor raise for OrdinaryDiffEqRosenbrock, OrdinaryDiffEqRosenbrockTableaus, OrdinaryDiffEqBDF, and the AD / Downstream test environments. At lower 0.13 floors, Downgrade Sublibraries exposed AutoEnzyme order/step failures (SciML#3987). Compat-only; no source or test changes. Substantive Downgrade fixes are in SciML#4012. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Conservative floor raise for OrdinaryDiffEqRosenbrock, OrdinaryDiffEqRosenbrockTableaus, OrdinaryDiffEqBDF, and the AD / Downstream test environments. At lower 0.13 floors, Downgrade Sublibraries exposed AutoEnzyme order/step failures (#3987). Compat-only; no source or test changes. Substantive Downgrade fixes are in #4012. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
|
Split this into one PR per issue, since the three changes here fail independent CI jobs and are independently reviewable:
The third change here (AMF using SciMLOperators, LinearAlgebra # v1.24.4
J = MatrixOperator(rand(4,4)) + MatrixOperator(rand(4,4))
W = SciMLOperators.WOperator{true}(I, 1.0, J, rand(4))
convert(AbstractMatrix, W)
# MethodError: Cannot `convert` an object of type Matrix{Float64}
# to an object of type SciMLOperators.AddedOperator{...}Once that ships, AMF should need only a SciMLOperators floor bump rather than a test-side workaround — worth avoiding the tolerance loosening if possible. Also found while going through master: |
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
Substantive fixes for Downgrade CI without package version floor bumps.
SparseArraysin[extras]Pkg.testaborts under Downgradeode_initdt_tests.jl: missing@testsetendROS34PW1a(linsolve=KrylovJL())for dense operator-jac refsSibling PR (floors only)
#4009 — Enzyme
0.13→0.13.180.Independent of this PR; either order is fine.