Lowstorage 3sp#3686
Closed
singhharsh1708 wants to merge 6 commits into
Closed
Conversation
This was referenced May 27, 2026
Closed
Closed
Closed
Closed
added 5 commits
May 27, 2026 14:21
singhharsh1708
force-pushed
the
lowstorage-3sp
branch
from
e574b7c to
e8664bd
Compare
Contributor
Author
|
Closing in favour of the consolidated approach in #3683 — the substantive change (consolidating RK46NL into LowStorageRKTableau{TwoN}) will be done there instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the 3Sp and 3SpFSAL families (CKLLSRK43_2, CKLLSRK54_3C, CKLLSRK95_4S/4C/4M, RDPK3Sp35/49/510, RDPK3SpFSAL35/49/510) to plain-dispatch step implementations in
generic_low_storage_perform_step.jl, dispatched onLowStorageRK3SpConstantCacheandLowStorageRK3SpFSALConstantCacherespectively.Thin wrappers in
low_storage_rk_perform_step.jldelegate to the generic implementations.Part of the stacked series: #3683 (2N) → #3684 (2C) → #3685 (3S) → #3686 (3Sp + 3SpFSAL) → #3687 → #3688.
Test plan