Lowstorage 2c#3684
Closed
singhharsh1708 wants to merge 4 commits into
Closed
Conversation
This was referenced May 27, 2026
Closed
Closed
Closed
Closed
f8cd3a8 to
ccc511a
Compare
Contributor
Author
|
Closing in favour of the consolidated approach in #3683 — the substantive change (consolidating RK46NL into LowStorageRKTableau{TwoN}) will be done there instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the 2C family (CFRLDDRK64, TSLDDRK74) to use
LowStorageRKTableau{:two_c}in place of the deletedLowStorageRK2CConstantCache.Adds
_perform_step_oop!/_perform_step_iip!dispatch for:two_cingeneric_low_storage_perform_step.jl. Thin wrappers inlow_storage_rk_perform_step.jldelegate to the generic implementations.Part of the stacked series: #3683 (2N) → #3684 (2C) → #3685 → #3686 → #3687 → #3688.
Test plan