Support DataInterpolations 9 - #499
Merged
ChrisRackauckas merged 1 commit intoAug 10, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
CI follow-up: all ModelingToolkitStandardLibrary Core, QA, downgrade, docs, Runic, and typos checks pass. The long ModelingToolkit downstream job failed after 3h39m in ModelingToolkit's pre-existing This is tracked at SciML/ModelingToolkit.jl#4925 and fixed by the separately validated draft SciML/ModelingToolkit.jl#4927. The failing downstream job is https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/31367386793/job/93388623849. No MTSL resolver or test failure appears in the log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Widen the DataInterpolations compatibility entry to include version 9 and exercise the version-correct BSpline constructor in the existing interpolation test. This lets current ModelingToolkit/ModelingToolkitBase downstream tests resolve the shared FindFirstFunctions 3 dependency while retaining the DataInterpolations 8 test path.
Fixes #498.
Root cause
SciMLBase 3.35 and later require FindFirstFunctions 3, while DataInterpolations 8 is restricted to FindFirstFunctions 1.3–1.8. DataInterpolations 9 moved to FindFirstFunctions 3, but it also removed the old
pVecTypepositional BSpline constructor argument, so widening compat alone makestest/sources.jlerror.Verification
Failing before, from MTSL
dd512368441fc4684b2a6f6a011447dbe5cd80c8against clean ModelingToolkitd7f3ad523c00b4150281f259d1e97618fba79982:With only the compat widened, the existing Core test discriminated the constructor change:
With this patch:
GROUP=Core julia +1.12.6 --startup-file=no --project=. -e 'using Pkg; Pkg.develop(path="../ModelingToolkit.jl/lib/ModelingToolkitBase"); Pkg.develop(path="../ModelingToolkit.jl"); Pkg.update(); Pkg.test(; coverage=false)'resolved DataInterpolations 9.2.0, FindFirstFunctions 3.2.1, and SciMLBase 3.44.0, then exited 0:
Additional local checks:
No docs build was run because this changes no public API or documentation.
Please ignore this draft until it has been reviewed by @ChrisRackauckas.