build: bump ModelingToolkitBase for DAE NLStep hook - #4920
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
build: bump ModelingToolkitBase for DAE NLStep hook#4920ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This was referenced Aug 10, 2026
Member
|
Already done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
What changed and why
Bump ModelingToolkitBase from 1.62.0 to 1.63.0 so the public
generate_DAENLStepDatahook added on master can be released. ModelingToolkit master currently permits and resolves registered ModelingToolkitBase 1.62.0 on Julia 1.10, but that release predates the hook and causes ModelingToolkit precompilation to fail.This is a standalone SemVer-minor release bump. ModelingToolkit already accepts all 1.x ModelingToolkitBase releases through its existing 1.62 compat entry.
Regression evidence
Failing before, from the working-folder parent with clean ModelingToolkit commit
d7f3ad523c00b4150281f259d1e97618fba79982, clean LinearSolve commitf5b63ee4ed69a7558d2133a27d73805556d37a16, and Julia 1.10.11:timeout 3600 julialauncher +1.10 --project=mtk-clean -e 'using Pkg; Pkg.develop(PackageSpec(path=abspath("mtk-ls-clean"))); Pkg.update(); using ModelingToolkit'Git bisect identified
4ae2e03f00957017e6a28e96196c338f3e944bfaas the first bad commit.Passing from the ModelingToolkit checkout with the bumped local ModelingToolkitBase release contents:
timeout 3600 julialauncher +1.10 --project=. -e 'using Pkg; Pkg.develop(PackageSpec(path=abspath("lib/ModelingToolkitBase"))); Pkg.develop(PackageSpec(path=abspath("../mtk-ls-clean"))); Pkg.update(); using ModelingToolkit; println("MODELINGTOOLKIT_LOAD_OK")'Verification
env GROUP=InterfaceI julialauncher +1.10 --project=. -e 'using Pkg; Pkg.test()'env GROUP=QA julialauncher +1.10 --project=. -e 'using Pkg; Pkg.test()'The Aqua piracy failure reproduces on clean master. Its QA lane has been red since the lane was introduced by
9fadfdca1e0c119ce7d109ae7fa5416ca05ce200. Draft PR 4907 fixes the four JumpProcesses-related methods; the ten historicalSymbolicUtils.Code.toexprmethods are tracked by issue 4670. This version-only diff does not touch those methods.Additional checks:
git diff --check upstream/master...HEAD: clean.typos lib/ModelingToolkitBase/Project.toml: clean.CI status
CI completed with 76 passing, 14 failing, and 3 skipped checks. None of the failures exercise the changed version line:
The operation was canceled, without a test failure: root QA on Julia 1, root InterfaceII on Julia pre, root Optimization on Julia lts, and ModelingToolkitBase Optimization on Julia lts/pre.Not verified
Review note
The judgment call is a minor rather than patch bump because
generate_DAENLStepDatais new public API.Links