Repository navigation
Drop unused NLsolve test extra - #242
Merged
ChrisRackauckas merged 1 commit intoAug 26, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
NLsolve is not used in src or test/*.jl. It was only in [extras] so NonlinearSolveNLsolveExt would load; tests never call it. Registered NonlinearSolve 4.x WeakCompat pins NLsolve to 4.5.0-4, so requiring NLsolve 5 makes Downgrade --min=@deps unsatisfiable. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop unused NLsolve from
[extras]/[targets].test/[compat]. Tests useNewtonRaphsonandSimpleLimitedMemoryBroydenfrom NonlinearSolve, not NLsolve. NLsolve was only pulled soNonlinearSolveNLsolveExtwould load.Registered NonlinearSolve 4.x WeakCompat is
NLsolve = "4.5.0-4"(["3 - 4.9"]and["4.10 - 4"]in General). NLsolve 5 is live. With NLsolve kept as a test extra, Downgrade promotes extras into the merged resolve, so--min=@depsrequires NLsolve 5 next to NonlinearSolve 4 and is unsatisfiable. SciML/NonlinearSolve.jl#1198 setNLsolve = "5"in source; that is not registered yet (latest NS is 4.28.0, still pinned to NLsolve 4.5-4).This supersedes #241 (
NLsolve = "4, 5"), which keeps extra major 4 so the min floor can still pick 4.5.1. NLsolve is unused here, so the extra should go rather than keep major 4.Project.tomlNLsolvefrom[compat],[extras],[targets].testNonlinearSolve stays at
"4".Verification
Local Julia 1.10.11. Resolver.jl
--min=@deps --julia=1.10on a merged extras project (same extras-to-deps promotion as julia-downgrade-compat):Before (
origin/main,NLsolve = "5"extra): UnsatisfiableAfter (NLsolve extra removed): EXIT 0. NLsolve is not in the resolved set. Direct floors include NonlinearSolve 4.17.1, OrdinaryDiffEq 7.0.0, OrdinaryDiffEqAdamsBashforthMoulton 2.0.0, ForwardDiff 1.0.1, Lux 1.16.0, SciMLSensitivity 7.105.0.
GROUP=CorePkg.test()without NLsolve extra (test env Status has NonlinearSolve v4.28.0 and no NLsolve):Started 2026-08-26T11:07:27-04:00, finished 2026-08-26T11:38:44-04:00.
Not verified
docs// public API change)This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code