Repository navigation
Keep NLsolve 5 declared; min floor stays 4 - #241
Closed
ChrisRackauckas-Claude wants to merge 2 commits into
Closed
ChrisRackauckas-Claude wants to merge 2 commits into
ChrisRackauckas-Claude wants to merge 2 commits into
Conversation
Registered NonlinearSolve 4.10-4 WeakCompat is NLsolve 4.5.0-4. NLsolve 5 makes extras-merged Downgrade unsatisfiable. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com>
NonlinearSolve 4 WeakCompat-pins NLsolve 4.5.0-4. Compat 4, 5 lets --min=@deps pick 4.5.1 while the live latest major stays declared. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude <noreply@anthropic.com>
ChrisRackauckas-Claude
changed the title
Member
Author
|
Superseded by #242 — NLsolve is unused in src/tests, so the extra is dropped instead of keeping major 4. |
Member
Author
|
Closing extras workaround. Already superseded by merged #242 (drop unused NLsolve extra). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep NLsolve 5 declared; Downgrade
--min=@depsstill pins 4.5.x.Follow-up to #239 (merged). NLsolve 5 is live (
Pkg.add5.0.1 succeeds). Registered NonlinearSolve 4.0.0–4.25.0 WeakCompat is NLsolve 4.5.0–4.5.1 only.Compat
"4, 5"keeps the live latest major;--min=@depstakes 4 and the NS pin raises it to 4.5.1.Local Julia 1.10 Resolver.jl
--min=@deps+GROUP=CorePkg.test(; allow_reresolve=false):5): Unsatisfiable — NS 4.0.0–4.25.0 works with NLsolve only at 4.5.0–4.5.1; compat leaves NLsolve ≥ 5.0.0 (DeepEquilibriumNetworks-downgrade-before.log)4, 5): NLsolve v4.5.1, ForwardDiff v1.0.1, tests passed (DeepEquilibriumNetworks-downgrade.log)Project.tomlNLsolve54, 5Bound-only. ForwardDiff 1 / LuxTestUtils 2 stay. No OrdinaryDiffEqCore 5 / DiffEqDevTools 4.
This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code