Skip to content

oidc_auth: guard group removal against out-of-band group deletion #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davmlaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oidc_auth: guard group removal against out-of-band group deletion #1637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions oidc_auth/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ def create_or_update(self, user: User, claims):
added_groups = groups.difference(django_groups)

for removed_group in removed_groups:
group = Group.objects.get(name=removed_group)
user.groups.remove(group)
# Group may have been deleted out-of-band between logins - skip if gone
if group := Group.objects.filter(name=removed_group).first():
user.groups.remove(group)

for added_group in added_groups:
# note that we trust the OIDC connector as it can already make admins
Expand Down
Loading