oidc_auth: guard group removal against out-of-band group deletion#1637
Open
davmlaw wants to merge 1 commit into
Open
oidc_auth: guard group removal against out-of-band group deletion#1637davmlaw wants to merge 1 commit into
davmlaw wants to merge 1 commit into
Conversation
When removing a group a user has left, look it up with .filter(...).first() so a group deleted out-of-band between logins no longer raises during login.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Written by Claude
When syncing a user's groups at login, the removed-groups branch used
Group.objects.get(name=...), which raisesGroup.DoesNotExistif a group was deleted out-of-band between logins. Use.filter(...).first()and skip when absent, so login is robust to that data state.