[Improve] Deliver onboarding automation reports by Email as a fallback - #2519
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
[Improve] Deliver onboarding automation reports by Email as a fallback#2519roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
![roomote-community[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| ? await getCustomAutomationById(recommendation.automationId, tx) | ||
| : null; | ||
| const reportTarget = enabled | ||
| ? await resolveSetupAutomationReportTarget(auth.userId, tx) |
Contributor
There was a problem hiding this comment.
reportTarget is resolved before the existing-target guard below. That resolver probes chat DMs; the Slack and Teams probes can open/create a direct-message conversation. Re-enabling a recommendation that already has an explicit destination therefore creates unrelated DM channels (and makes external calls while holding the recommendation transaction lock) even though the result is discarded at line 2628. Resolve the fallback only when the existing target is absent or unconfigured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Recommended automations should deliver useful reports immediately without replacing communication destinations users have already configured. Email now provides a safe final fallback when no chat route is available.
Impact
Onboarding-created custom automations default to the best existing chat destination, then Email, and otherwise retain the existing no-destination behavior. Existing explicit automation targets are left unchanged.