[Improve] Use consistent default destinations for automations - #2546
Merged
mrubens merged 5 commits intoSep 11, 2026
Conversation
…omation-destinations-3gn2vpq0ev6e1
Contributor
|
No new code issues found. See task
Reviewed 54542d5 |
…omation-destinations-3gn2vpq0ev6e1
Contributor
Author
|
Fixed both rereview findings in 54542d57: disconnected provider mappings no longer become defaults, and reapplied recommendations resolve against their persisted owner. All three review findings are checked off, all review threads are resolved, Roomote found no new code issues, and every required GitHub check passes. See the review task. |
mrubens
marked this pull request as ready for review
September 11, 2026 19:50
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 11, 2026 19:50
mrubens
deleted the
feature/shared-automation-destinations-3gn2vpq0ev6e1
branch
September 11, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Automation entry points previously derived defaults independently, and the onboarding-specific implementation in #2519 would have added another separate waterfall. A shared resolver keeps precedence, validation, and provider support consistent without changing canonical target storage or ownership rules.
Impact
New automation defaults now select the same best usable destination across onboarding and settings without exposing privileged shared channels to members. Built-in runners remain limited to their declared chat capabilities, while custom automations may use verified Email as the final delivery fallback; unresolved automations remain available in the task UI without an unusable persisted target.