Code auto format config file - #62
Merged
Merged
Conversation
Move release internals out of the root Makefile so future tools can live under tools/ while preserving the existing user-facing commands. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep release manager verification artifacts out of version control. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
RomanAlexandroff
left a comment
Owner
Author
There was a problem hiding this comment.
No blocking issues found.
The branch cleanly adds the root .clang-format and separates Firmware Release Manager internals from the root Makefile, making the root file a much smaller command dispatcher. The Python extraction keeps the original release and manifest behavior while making the logic easier to read and maintain.
Verified with Python compilation and Makefile dry-runs; no actual firmware release or manifest publish was executed.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.clang-formatderived from Arduino IDE 2’s default ClangFormat configuration and tuned toward The Norm Version 3 formatting where ClangFormat supports it.ft_/FT_prefix rules explicitly out of scope for this project.Makefilestays a user-facing entrypoint, while Firmware Release Manager internals now live undertools/firmware_release_manager/.Norm / ClangFormat Gaps
ClangFormat cannot enforce every Norm rule. These still require manual review or a dedicated linter:
s_,t_,u_,e_,g_, snake_case, and English identifiers.return (value);parentheses.for,do while,switch,case,goto, ternary operators, and VLAs.Test Plan
python3 -m py_compile tools/firmware_release_manager/*.pymake helpmake -C tools/firmware_release_manager helpmake -n releasemake -n publish-manifestmake -n format all