Repository navigation
feat(panel): links to a pull request's own comments on GitHub open in its tab - #3887
Merged
Merged
Conversation
A review thread gets a Luke link of its own, LINK_PLACE.PULL_REQUEST_THREAD (`…/agent/<id>/changes/<conversation|files>/thread/<threadId>`), routed by openLink to the agent's Pull request tab on the view it names, which brings the thread into view by GitHub's node id. - Conversation → Files changed: a thread's file and lines, or its ⋯'s View in Files changed, opens the file (collapsed or folded as viewed), clears a filter hiding it, shows a minimized line's chip, opens the thread, scrolls Pierre's list to its line (or the file's above-the-diff list for a line no hunk shows or an outdated thread), lights its lines until its ring ends, and moves the focus to it. A thread whose file left the diff says so and is shown in the Conversation instead. - Files changed → Conversation: View in Conversation scrolls to, opens, rings and focuses the card there, standing through Hide resolved and Hide bots. - Copy link in a thread's ⋯ copies its link in the view it is drawn in. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
… its tab In a Pull request tab's description and comments, a link to one of that pull request's own comments on GitHub opens the comment in the tab rather than the browser: `#discussion_r<id>` (or `/files#r<id>`) through its thread's Luke link route into the Conversation, and `#issuecomment-<id>` or `#pullrequestreview-<id>` brought into view in the Conversation, ringed and focused, standing through its filters. A link to a comment the conversation read did not reach, or to anything else, still opens on GitHub. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 19, 2026
…tanding Each press of a link to one of the pull request's own comments is a new ask from a counter the landing does not reset, and the anchors module and its test lead with their `name.ts -- purpose` headers. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
14 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3884, which adds the thread link and the jumps. This is item 4 of the deep-links work: a link in a PR's description or comments that points at one of that PR's own comments on GitHub now opens in the Pull request tab instead of the browser.
What it does
pull-request-anchors.ts(anchorIn) reads a GitHub link against the conversation the tab already read:…/pull/N#discussion_r<id>,…/pull/N/files#r<id>LINK_PLACE.PULL_REQUEST_THREAD, Conversation) from #3884…/pull/N#issuecomment-<id>,…/pull/N#pullrequestreview-<id>The match uses the
urleach entry and thread comment already carries, so it needs no service change.How
OpenHereFirst(use-open-link): asks the tab's opener first and any place's opener around it after, so the Inbox's own opener still works.Anchoredwraps only the PR's own words: the description, entries and thread comments, in either view. "N more replies on GitHub" and "N earlier comments on GitHub" still leave for GitHub on purpose.useLandedEntry).Tests
pull-request-anchors.test:#diff-…anchor, or a non-GitHub host names nothingagent-pull-request-tab.test: in the description, a#discussion_rlink takes the thread's route; an#issuecommentlink rings and focuses the note; an unread#issuecomment-99still opens GitHub.Checks
Made with Luke