Repository navigation
feat(panel): fold and stick the PR tab's Conversation sections, filters in the heading - #4150
Merged
Merged
Conversation
…ons, filters in its heading The Description and the Conversation each fold under a heading pressed across its row, kept for every pull request, and the heading sticks to the view's top while its section is in view, what scrolls under it fading beneath it. Hide resolved and Hide bots move into the Conversation's heading as compact chips. A link to a thread opens a folded Conversation and lands clear of the stuck heading. The Checks list every check rather than folding past five. Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
… in a plain note Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luke-agent Bot
added a commit
that referenced
this pull request
Oct 20, 2026
Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
…ecks does Co-authored-by: luke-agent[bot] <339870089+luke-agent[bot]@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Oct 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Asked for: make Description and Conversation collapsible and sticky, move Hide resolved and Hide bots into the Conversation header, use the fade effect, and drop "Show all N" / "Show less" from Checks.
Conversation pane (
agent-pull-request-tab.tsx,tasks.css)aria-expanded. They're built on the app's own disclosure (Fold,FoldSummary,DisclosureChevron,FoldBody), so they get its motion, its reduced motion, and find-in-tab support. Both start open.conversation-filters.ts, keyluke.conversation-filters). There's one choice per section, the same for every pull request, and a change in one tab shows at once in the others. Choices stored before this change still read correctly, and both sections default to open.position: stickyat the scroller's top, 32px tall (--luke-scroll-band), on the panel's--luke-color-wellground. A sticky box stands only inside its own section, so the next section's heading pushes the previous one off.ScrollArea's band fade, the one the Code and Call logs use under their checkpoints (fade="start",fadeInset="band"): content dissolves just beneath the stuck heading instead of being cut at its edge. The Conversation view'sDetailPagecolumn wasn't aScrollArea, and under 720px its body, not the column, was the scroller. So the view is now aScrollAreaholding a.pull-request-pageat the same measure and inset theDetailPagegave it. Checks keeps itsDetailPage. The header-fold scroller selector names the new scroller.ChipFILTER+COMPACT,aria-pressed, the same look as the reactions) with their counts, at the right end of the Conversation heading. Their tooltips, descriptions and stored choice are unchanged. Pressing a chip doesn't fold the section. The separate filter row and its CSS are gone.centreCardnow centres the card in the space under the scroller's scroll padding (the stuck heading plus the fade). A card taller than that space lands with its top just under the heading.Checks pane
CHECKS_UNFOLDED,unfoldedCountOf, and theshowAll/SHOW_LESSstrings are deleted.Screenshots
Every shot is the side panel with fixture data, at about 900px and 600px wide, in light and dark.
Evidence
pnpm check:affected:@luke/desktop#typecheckran out of memory in the sandbox (exit 137), as on fix(panel,ui): move the Pull request header's ⋯ into the side panel's, one pill size #4101, so I ran the parts per package:tsc --noEmitfor@luke/panelpasses;@luke/desktoptypecheck passes with--max-old-space-size=4096.pnpm exec vitest run --project panel: 264 files, 2718 tests pass../scripts/oxlint.sh: 0 warnings, 0 errors.pnpm knip: clean.biome checkon the touched files: clean../scripts/repository-checks.sh: pass.cd apps/desktop && node scripts/build.mjs: builds within the bundle budget.agent-pull-request-tab.test.ts):ScrollAreawithdata-fade="start"anddata-fade-inset="band". Each section's heading is thesummary.pull-request-section-headband with itsh3and chevron, and the filters stand in the Conversation heading's end, with no filter row.aria-pressed) and checks that a press folds nothing. The phone header-fold tests scroll the new scroller.Invariants
./scripts/check.shgreen. (CI)LUKE_UPDATE_FIXTURESnot run). (CI)astype assertion outside the allowlisted files. (CI via anti-slop)Effect.runPromise/runSync/runForkoutside the runtime edges. (CI)setTimeout/setInterval/new Promise/AbortController/fs.watch. (CI)CLAUDE.md/AGENTS.mdsentence naming a changed part is edited. (None names these parts.)PRIVACY.mdunchanged.package.jsondeps match what the sources import. (No new imports outside@luke/ui.)Notes
Made with Luke