Skip to content

feat(desktop,service,features): draw changed images before and after in Files changed #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-agent merged 4 commits into from
Oct 18, 2026
Merged

feat(desktop,service,features): draw changed images before and after in Files changed #3638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a0ba5f
feat(desktop,service,features): Files changed draws a changed image b…
dastratakos Oct 18, 2026
cd9bfe9
fix(desktop): a changed image reads a failed side again on refresh, o…
dastratakos Oct 18, 2026
1af5d5d
fix(desktop): an image's comparison and slider outlast a refresh of t…
dastratakos Oct 18, 2026
0cae842
fix(desktop): after a refresh, an image far from the view waits to co…
dastratakos Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 88 additions & 0 deletions apps/desktop/src/renderer/styles/tasks.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1535,6 +1535,94 @@
font-size: 12.5px;
}

/* A changed image in Files changed's list (image-diff.tsx), under its
header in place of lines, as its lead (diff-view/index.ts): its two sides beside each other, each on a
checkerboard that shows what is transparent, or the after laid over the
before, swiped or faded with the slider under them. */
.image-diff {
display: flex;
flex-direction: column;
align-items: center;
gap: var(--luke-space-8);
padding: var(--luke-space-12);
font-family: var(--luke-font-sans);
}

.image-diff-modes {
display: flex;
justify-content: center;
}

.image-diff-sides {
display: flex;
width: 100%;
flex-wrap: wrap;
justify-content: center;
gap: var(--luke-space-12);
}

.image-diff-side {
display: flex;
min-width: 0;
flex: 1 1 200px;
flex-direction: column;
align-items: center;
gap: var(--luke-space-6);
margin: 0;
}

.image-diff-side > figcaption {
color: var(--luke-color-text-muted);
font-size: 11.5px;
}

.image-diff-picture,
.image-diff-stack {
max-width: 100%;
max-height: 480px;
border: 1px solid var(--luke-color-border);
background:
repeating-conic-gradient(var(--luke-color-surface) 0 25%, transparent 0 50%) 0 0 / 16px 16px;
}

.image-diff-picture {
object-fit: contain;
}

.image-diff-stacked {
display: flex;
max-width: 100%;
flex-direction: column;
align-items: center;
gap: var(--luke-space-8);
}

/* The two sides stand in one cell of a grid, as large as the larger, the
after over the before: each fills the cell, scaled to fit, on a
checkerboard of its own, so the after at full strength or swiped all the
way hides the before however their sizes differ. */
.image-diff-stack {
display: grid;
}

.image-diff-stack > .image-diff-picture {
width: 100%;
height: 100%;
grid-area: 1 / 1;
border: 0;
background-color: var(--code-ground);
}
Comment thread
luke-agent[bot] marked this conversation as resolved.

.image-diff-slider {
width: min(320px, 100%);
}

.image-diff-note {
margin: 0;
color: var(--luke-color-text-muted);
font-size: 12.5px;
}

/* The tree's search field and its filter, in one row over the tree. */
.file-tree-search {
display: flex;
Expand Down
Loading
Loading