Repository navigation
feat: support installing via Homebrew - #3
Merged
Merged
Conversation
portmap install now writes Homebrew's stable opt path into the launchd plist instead of the versioned Cellar keg, which brew cleanup deletes after an upgrade. Documents the brew tap install and adds a release workflow that bumps the tap formula when a version tag is pushed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares portmap for distribution through a Homebrew tap (
RakshithBhat03/homebrew-tap).portmap installcanonicalizes its own path, which under Homebrew resolves to the versioned keg (/opt/homebrew/Cellar/portmap/0.1.0/bin/portmap).brew upgradefollowed bybrew cleanupdeletes that keg, so the launchd agent would stop working without any error. It now rewrites keg paths to the stable<prefix>/opt/portmap/...symlink. Paths outside Homebrew are left as they are.brew services, and warns against running bothbrew servicesandportmap install(they'd fight over port 7878)..github/workflows/release.yml: on av*tag push, updatesurl/sha256in the tap's formula. Needs aHOMEBREW_TAP_TOKENsecret (fine-grained PAT, contents read/write on the tap repo only). Without it, the job fails with a clear error.Verified with
cargo fmt --check,cargo clippy --all-targets -- -D warnings, andcargo test(72 passed, including new tests for the keg-to-opt path mapping).