Skip to content

BUG: Fix black frames with --cudacg and spatial TV #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axel-grc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUG: Fix black frames with --cudacg and spatial TV #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4a142
BUG: Fix black frames with --cudacg and spatial TV
axel-grc Sep 8, 2026
35b572f
TEST: Add a new test in rtkfourdroostertest
axel-grc Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions include/rtkTotalVariationDenoiseSequenceImageFilter.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,18 +124,18 @@ TotalVariationDenoiseSequenceImageFilter<TImageSequence>::GenerateData()
{
int Dimension = TImageSequence::ImageDimension;

// Declare an image pointer to disconnect the output of paste
typename TImageSequence::Pointer pimg;
// Accumulate all frames in place into a single, freshly allocated buffer so
// that the accumulator never aliases an upstream buffer.
typename TImageSequence::Pointer pimg = TImageSequence::New();
pimg->CopyInformation(this->GetOutput());
pimg->SetRegions(this->GetOutput()->GetLargestPossibleRegion());
pimg->Allocate();
pimg->FillBuffer(0);
m_PasteFilter->SetInPlace(true);
m_PasteFilter->SetDestinationImage(pimg);

for (unsigned int frame = 0; frame < this->GetInput(0)->GetLargestPossibleRegion().GetSize(Dimension - 1); frame++)
{
if (frame > 0) // After the first frame, use the output of paste as input
{
pimg = m_PasteFilter->GetOutput();
pimg->DisconnectPipeline();
m_PasteFilter->SetDestinationImage(pimg);
}

m_ExtractAndPasteRegion.SetIndex(Dimension - 1, frame);

m_ExtractFilter->SetExtractionRegion(m_ExtractAndPasteRegion);
Expand Down
25 changes: 25 additions & 0 deletions test/rtkfourdroostertest.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,31 @@ rtkfourdroostertest(int, char *[])

CheckImageQuality<VolumeSeriesType>(rooster->GetOutput(), join->GetOutput(), 0.25, 15, 2.0);
std::cout << "\n\nTest PASSED! " << std::endl;

std::cout << "\n\n****** Case 5: CUDA forward and back projectors, CUDA conjugate gradient, "
"spatial TV denoising (regression test for black frames) ******"
<< std::endl;

rooster->SetBackProjectionFilter(ROOSTERFilterType::BP_CUDAVOXELBASED); // Cuda voxel based
rooster->SetForwardProjectionFilter(ROOSTERFilterType::FP_CUDARAYCAST); // Cuda ray cast

rooster->SetPerformPositivity(false);
rooster->SetPerformMotionMask(false);
rooster->SetPerformTVSpatialDenoising(true);
rooster->SetPerformWaveletsSpatialDenoising(false);
rooster->SetPerformTVTemporalDenoising(false);
rooster->SetPerformL0TemporalDenoising(false);
rooster->SetPerformWarping(false);
rooster->SetComputeInverseWarpingByConjugateGradient(false);
rooster->SetUseNearestNeighborInterpolationInWarping(false);

// With --cudacg and spatial TV, every frame but the first used to come out
// black (all zeros). The spatial TV produces a slightly different result than
// other regularization modes, so use a looser tolerance here.
rooster->SetCudaConjugateGradient(true);
TRY_AND_EXIT_ON_ITK_EXCEPTION(rooster->Update());
CheckImageQuality<VolumeSeriesType>(rooster->GetOutput(), join->GetOutput(), 0.3, 14, 2.0);
std::cout << "\n\nTest PASSED! " << std::endl;
#endif

itksys::SystemTools::RemoveFile(signalFileName);
Expand Down