Conversation
Fixes RTKConsortium#888. The total variation denoise sequence filter reused the paste output as the destination for every frame following the first. On the ROOSTER main loop iterations, that accumulator could alias the fed-back CG volume through the CUDA buffer pool, so downstream spatial TV zeroed every frame but the first. Accumulate all frames in place into a single, freshly allocated destination buffer, which can never alias an upstream buffer.
The test check for black frames with --cudacg and spatial TV
axel-grc
changed the title
SimonRit
requested changes
Sep 10, 2026
SimonRit
left a comment
SimonRit
left a comment
Collaborator
There was a problem hiding this comment.
rtk::TotalVariationDenoiseSequenceImageFilter is not InPlace. Maybe setting the PasteImageFilter to InPlaceOff would have solved the issue more clearly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888 .
The total variation denoise sequence filter reused the paste output as the
destination for every frame following the first. On the ROOSTER main loop
iterations, that accumulator could alias the fed-back CG volume through the
CUDA buffer pool, so downstream spatial TV zeroed every frame but the first.
Accumulate all frames in place into a single, freshly allocated destination
buffer, which can never alias an upstream buffer.