Skip to content

[CP 341] fix: move BASE_IMAGE_REGISTRY ARG to global scope in Dockerfile templates #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuva29 merged 1 commit into from
Jun 26, 2026
+1 −6
Merged

[CP 341] fix: move BASE_IMAGE_REGISTRY ARG to global scope in Dockerfile templates #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions internal/kmmmodule/dockerfiles/DockerfileTemplate.rhel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ RUN dnf clean all && \

RUN depmod ${KERNEL_VERSION}

ARG BASE_IMAGE_REGISTRY=registry.access.redhat.com

FROM ${BASE_IMAGE_REGISTRY}/redhat/ubi$$MAJOR_VERSION

ARG KERNEL_FULL_VERSION
Expand Down
3 changes: 1 addition & 2 deletions internal/kmmmodule/dockerfiles/DockerfileTemplate.srcimg.ionic.coreos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ ARG DTK_AUTO
ARG RHEL_VERSION
ARG SOURCE_IMAGE_REPO=docker.io/library/ionic-srcimg
ARG DRIVERS_VERSION
ARG BASE_IMAGE_REGISTRY=registry.access.redhat.com

FROM ${SOURCE_IMAGE_REPO}:${DRIVERS_VERSION} as sources
FROM ${DTK_AUTO} as builder
Expand Down Expand Up @@ -33,8 +34,6 @@ RUN mkdir -p /modules_files && \
cp -r /lib/modules/${KERNEL_VERSION}/extra/* /ionic_ko_files/ && \
cp -r /lib/modules/${KERNEL_VERSION}/kernel/* /kernel_files/ || true

ARG BASE_IMAGE_REGISTRY=registry.access.redhat.com

FROM ${BASE_IMAGE_REGISTRY}/ubi9/ubi-minimal

ARG KERNEL_VERSION
Expand Down
2 changes: 0 additions & 2 deletions internal/kmmmodule/dockerfiles/DockerfileTemplate.ubuntu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@ RUN mods_dir=/lib/modules/${KERNEL_FULL_VERSION}; \
# Regenerate dependency maps only for staged modules
depmod -b /staging ${KERNEL_FULL_VERSION}

ARG BASE_IMAGE_REGISTRY=docker.io

FROM ${BASE_IMAGE_REGISTRY}/ubuntu:$$VERSION

ARG KERNEL_FULL_VERSION
Expand Down
Loading