[CP 341] fix: move BASE_IMAGE_REGISTRY ARG to global scope in Dockerfile templates#102
Merged
yuva29 merged 1 commit intoJun 26, 2026
Conversation
…ates (#341) * fix: move BASE_IMAGE_REGISTRY ARG to global scope in Dockerfile templates Buildah treats ARG declarations after a FROM as stage-scoped, so BASE_IMAGE_REGISTRY declared between stages was invisible to the final-stage FROM instruction. This caused the build arg to resolve to an empty string, producing "FROM /ubi9/ubi-minimal" (invalid reference). Move the ARG before the first FROM where it is in true global scope and reachable by all FROM instructions. Fixes srcimg.ionic.coreos (broken) and ubuntu (latent same issue). Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com> * fix: remove redundant mid-file ARG BASE_IMAGE_REGISTRY in RHEL template Same cleanup as ubuntu template — line 1 already declares the ARG in global scope, so the re-declaration on line 30 between stages is redundant. Ensures all four Dockerfile templates follow the same pattern consistently. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Yuva Shankar <11082310+yuva29@users.noreply.github.com> Co-authored-by: Claude Opus 4 (1M context) <noreply@anthropic.com> (cherry picked from commit 0446b6c12d9ea516a52361ddf1a77ec604981233)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/network-operator#341