fix(workspace): force-close connection upon query TimeoutException (#333) - #337
Merged
Conversation
Closed
4 tasks
ZhuchkaTriplesix
added a commit
that referenced
this pull request
Jul 27, 2026
fix(workspace): force-close connection upon query TimeoutException (#333)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
TimeoutException):PostgresConnection,MysqlConnection,SqliteConnection) методыexecuteиexecuteWithTimeoutтеперь оборачивают вызовы к драйверам (_conn!.execute,rawQueryи т.д.) в блокtry/catch on TimeoutException. При возникновении таймаута немедленно вызываетсяunawaited(forceClose()), сбрасывающий TCP-соединение или дескриптор БД (_isConnected = false; _conn = null;), что предотвращает отравление протокола (protocol poisoning) рассинхронизированными кадрами или зависшим серверным потоком.PostgresSqlWorkspace,MysqlSqlWorkspace,SqliteSqlWorkspace) добавлены явные блокиon TimeoutException catch (e)перед остальными обработчиками (ServerException/catch). При таймауте также гарантированно вызываетсяunawaited(_lease?.connection.forceClose()), корректно обновляется статус ошибки в UI, а при следующем выполнении запроса_ensureLease()обнаруживает закрытое соединение и автоматически переподключает чистую TCP-сессию.connection_timeout_protocol_test.dart, проверяющий автоматический сброс соединения наTimeoutExceptionдля PostgreSQL, MySQL и SQLite.Как проверялось
flutter analyze— 0 проблем.flutter test— 825 из 825 тестов успешно пройдено.Closes #333