[stationary_densities] Fix typos and align with style manual#331
Conversation
- Fix "for all s" -> "for all x" in state space remark - Correct off-by-one comment on density dates (1,...,T) - Remove stray trailing comma in boxplot data display - "discrete-time" -> "discrete time" (noun usage) - Add missing period after Markov operator definition - Initialize X[0] in exercise 1 solution (was uninitialized np.empty) - Boxplot titles: label initial condition as X_0, not t - Comments: B ~ N(0, a_σ**2) since a_σ is the std dev Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Links: use intersphinx {doc} links for finite_markov references,
normalize outdated python-intro.quantecon.org domain, auto-title
link for arma
- Citation: use {cite:t} for in-sentence Hopenhayn-Rogerson reference
- Definitions: bold (not italic) for stochastic kernel, Markov
operator, look-ahead, stationary, global stability, ergodicity
- Math: square brackets for expectation, \mathrm{LN} for lognormal,
"CDFs" capitalization
- Figures: replace ax.set_title with mystnb caption on the main
example, caption the static stability figure, drop unneeded
figsize settings, format ex-3 panel titles to one decimal
- RNG: migrate to np.random.default_rng Generator API; seed scipy
.rvs calls via random_state for reproducibility
Verified by executing the full lecture via jupytext --to py and
inspecting all five generated figures.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Chihiro2000GitHub @xuanguang-li If either of you have time could you please review these changes, which should be in line with the manual, fix the build error (ask claude to investigate), and let me know when you are done? If you can't do it please pass it to @mmcky |
The auto-title link `[](arma)` was ambiguous: MyST found both a doc
target (Covariance Stationary Processes) and an equation labelled
`arma`, raising myst.xref_ambiguous. With warnings treated as errors
the book build failed. Use the explicit `{doc}` role to resolve to the
document while keeping the auto-generated title.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks, @mmcky, for fixing the compilation error. I’ll be able to review this lecture in one or two weeks, as I’m currently reviewing the conversion of DP Vol. II. Maybe we can discuss the schedule and decide how to proceed. @Chihiro2000GitHub |
|
Many thanks @mmcky |
|
Hi @jstac, @mmcky, @xuanguang-li, Sorry for the delayed response. Many thanks, @mmcky, for fixing this. Glad this has been resolved. Nice to meet you here, @xuanguang-li. |
Summary
Two commits cleaning up the
stationary_densitieslecture:1. Typos and minor code issues
1,...,T+1→1,...,T)X[0]in the exercise 1 solution (was uninitializednp.emptymemory)a_σis the standard deviation2. Style-manual alignment
{doc}links forfinite_markovreferences, normalized the outdatedpython-intro.quantecon.orgdomain, auto-title link forarma{cite:t}for the in-sentence Hopenhayn–Rogerson reference\mathrm{LN}for the lognormal, "CDFs" capitalizationax.set_title→mystnbcaption on the main example, caption for the static stability figure, dropped unneededfigsizesettings, ex-3 panel titles formatted to one decimalnp.random.default_rng()Generator API, withrandom_state=rngon all scipy.rvs()calls for reproducibilityDeliberate deviations from the style manual
figsize=(11, 8)on the 2×2 panel in the ex-2 solution: this repo has no series-wide figure-size default in_config.yml, and at matplotlib defaults the grid's labels collide. (The repo may want the standard figure-size config added separately.)mystnbcaptions break the PDF build insidesolutiondirectives, and the titles carry the per-panel initial conditions.\mathscr Dfor the set of densities (plainVerification
Converted with
jupytext --to pyand executed end-to-end — clean run. Visually inspected all five generated figures: density sequences converge, the look-ahead estimator remains visibly tighter than the kernel estimate, and the ex-2/ex-3 convergence patterns match the live site, so the surrounding narrative still holds. Note figures will differ from the live site in exact draws (PCG64 vs legacy global state) per the RNG migration guidance.🤖 Generated with Claude Code