Skip to content

Remove vertical texture seams from planet rendering - #139

Merged
Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/fix-longitude-texture-seam
Nov 13, 2026
Merged

Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/fix-longitude-texture-seam

Conversation

@Protonmatter

Copy link
Copy Markdown
Owner

Outcome

Removes the thin vertical stripe visible across Jupiter where longitude wraps from one edge of its 2-D map to the other. Implicit UV derivatives treated this jump as a whole-map pixel footprint and selected an excessively coarse mip. Display maps now use local-tangent longitude gradients with textureGrad, preserving ordinary mip smoothing. The same correction covers legacy moon maps and Venus's cloud shell.

Targets precision so the fix can join #137 before release.

Specification and traceability

  • Requirements: SOL-VIS-001, SOL-TEST-001
  • RFC: Not required; corrects sampling within the existing rendering contract.
  • ADR: Not required; no architectural change.
  • Governing specification: docs/rfcs/0007-illustrative-planet-looks.md, docs/plans/2026-09-13-planetary-appearance/RENDERING_CONTRACT.md
  • Non-goals: editing source imagery, changing camera/ephemeris data or altering registered-image sampling.

Correctness and risk

  • Inputs, outputs, and failure behavior: only unregistered equirectangular texture lookups change. Longitude gradients follow the local atan tangent; latitude and wrap modes remain unchanged.
  • Compatibility or migration: none.
  • Scientific/accuracy/provenance impact: source pixels, physical positions and lighting calculations are unchanged.
  • Privacy/security/dependency impact: none.
  • Release risk, monitoring, and rollback: localized shader change; revert this commit if visual regressions appear. GPU checks cover both base and physical shader variants.

UI and UX

  • Primary task and disclosure-level impact: removes the false seam on the planet disc.
  • Keyboard, focus, touch/pointer, responsive, and reduced-motion evidence: no control changes; focused Jupiter checked in paused Chromium.
  • Loading, empty, success, degraded, unavailable, and error states: unchanged.
  • Manual usability/accessibility checks: inspected matching before/after Jupiter captures at 2026-11-12T18:51:58.751Z. The stripe disappears. Physical-device/native-GPU checks remain unavailable.

Validation evidence

  • Unit tests cover positive, boundary, and negative cases where applicable.
  • Contract/integration tests cover producer-consumer boundaries where applicable.
  • Browser end-to-end and visual assertions cover user-visible rendering where applicable.
  • Deterministic generation/accuracy checks pass where applicable.
  • Rust, Python, Node, and whole-web coverage gates remain at least 90%. Awaiting this PR's CI.
  • Locally unavailable checks are named and left to required CI.

Commands and results:

New real-GPU seam cases on previous shader -> four failures: display, illustrative planet, legacy moon, Venus shell
npm test -> 2297 passed, zero failed
python tools/typecheck_web.py -> 152 files clean
node tools/validate_module_graph.mjs -> valid
node tools/planet_appearance_validation.mjs --browser=/usr/bin/chromium -> 120/120 passed
Same GPU gate against newly bundled preview -> 120/120 passed
python tools/build_web.py with existing verified WASM -> staged successfully
python tools/validate_sdlc.py -> passed
python tools/validate_docs.py -> passed
Independent review -> no actionable findings; independently passed 24 focused tests and 120 GPU checks

The GPU regression includes a minified checkerboard so disabling mip smoothing cannot substitute for the seam correction. Local browser checks used SwiftShader.

Documentation

  • README and contributor instructions remain accurate.
  • Specifications, requirements, RFC/ADR, and implementation plan are updated where affected; this restores the existing contract.
  • Operations, readiness, status, roadmap, and handoff are updated when affected; no operational change.
  • User-visible claims and help match implemented behavior.

@Protonmatter
Protonmatter marked this pull request as ready for review November 13, 2026 02:36
@Protonmatter
Protonmatter merged commit 402eb29 into precision/verified-readiness-20261109 Nov 13, 2026
22 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T02:37:21.493437Z 21b7668 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant