Repository navigation
Remove vertical texture seams from planet rendering - #139
Merged
Protonmatter merged 1 commit intoNov 13, 2026
Merged
Protonmatter merged 1 commit into
Protonmatter merged 1 commit into
Conversation
Protonmatter
marked this pull request as ready for review
November 13, 2026 02:36
Protonmatter
merged commit Nov 13, 2026
402eb29
into
precision/verified-readiness-20261109
22 checks passed
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Removes the thin vertical stripe visible across Jupiter where longitude wraps from one edge of its 2-D map to the other. Implicit UV derivatives treated this jump as a whole-map pixel footprint and selected an excessively coarse mip. Display maps now use local-tangent longitude gradients with
textureGrad, preserving ordinary mip smoothing. The same correction covers legacy moon maps and Venus's cloud shell.Targets precision so the fix can join #137 before release.
Specification and traceability
docs/rfcs/0007-illustrative-planet-looks.md,docs/plans/2026-09-13-planetary-appearance/RENDERING_CONTRACT.mdCorrectness and risk
UI and UX
Validation evidence
Commands and results:
The GPU regression includes a minified checkerboard so disabling mip smoothing cannot substitute for the seam correction. Local browser checks used SwiftShader.
Documentation