Skip to content

Fix remaining Earth seams across all planet rendering paths - #140

Merged
Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/fix-all-planet-texture-seams
Nov 13, 2026
Merged

Protonmatter merged 1 commit into
precision/verified-readiness-20261109from
codex/fix-all-planet-texture-seams

Conversation

@Protonmatter

Copy link
Copy Markdown
Owner

Outcome

Remove the remaining longitude-wrap stripes from Earth's surface, relief, ocean mask, night lights, and drifting clouds. Together with merged #139's shared sphere and Venus shader fixes, this covers all eight planets.

Earth now uses explicit, locally continuous texture gradients instead of implicit derivatives across the UV wrap. Ray derivatives are captured before divergent branches, including cloud-volume loops. The GPU gate exercises the production Earth shader; its diagnostic facade is retained in bundled builds.

Specification and traceability

  • Requirements: SOL-VIS-001, SOL-TEST-001.
  • RFC: docs/rfcs/0007-illustrative-planet-looks.md.
  • ADR: No new architectural decision; corrective texture filtering.
  • Governing specification: Existing rendering and illustrative-appearance contracts.
  • Non-goals: New source imagery, lighting changes, physical geometry, or scientific qualification.

Correctness and risk

  • Inputs/outputs: Existing maps and UV coordinates; corrected mip selection at wrap boundaries. No schema or migration.
  • Scientific/provenance impact: Source pixels, ephemeris, geometry, exposure, and lighting recipes unchanged. Cloud footprint calculations use a local spherical-shell approximation for illustrative volume samples.
  • Privacy/security/dependencies: No changes.
  • Release risk: GPU-driver-specific filtering remains a consideration. Revert this commit if needed. Targets precision; merging Merge verified-readiness precision work into master #137 remains the separate publishing step.

UI and UX

  • Removes visible map-wrap stripes without changing controls or loading/error states.
  • Packaged browser smoke: all eight planets, four camera azimuths each, fixed epoch, High quality, reduced motion; 32 frames with no page, engine, or WebGL errors. Representative captures visually inspected.
  • Keyboard/focus/touch behavior is unchanged; no new interaction testing in this patch.

Validation evidence

  • Existing JavaScript suite: 2,297 passed, zero failures.
  • Production shader GPU regressions: four original Earth seam cases failed before the fix; all 134 checks pass after it.
  • Both source and actual bundled release GPU gates pass, including cloud phase shifts, minification, ±80° latitude, and oblique views.
  • Independent review: initial missing bundled shader facade fixed; reviewer independently confirmed bundled 134/134 and no remaining actionable findings.
  • Typecheck: 152 files clean; module graph, SDLC, documentation validation, and diff checks pass.
  • Full Rust/Python/Node/web coverage gates: required CI pending.
  • Locally unavailable checks identified: Rust toolchain and native phone/GPU testing. Local preview reused the verified prior CI WASM artifact; browser checks used Chromium SwiftShader.

Commands/results:

npm test — 2297/2297
node tools/planet_appearance_validation.mjs --browser=/usr/bin/chromium --out=/workspace/sol-review-evidence/all-seams-green — 134/134
Bundled release planet appearance GPU gate — 134/134
All-planet packaged browser sweep — 32/32 frames, zero errors

Documentation

Existing requirements, RFCs, contributor instructions, and user-visible claims remain accurate; this corrects filtering within the existing rendering behavior. Validation evidence and qualification limits are recorded above.

@Protonmatter
Protonmatter marked this pull request as ready for review November 13, 2026 20:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T20:33:06.747328Z ac363c3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Protonmatter
Protonmatter merged commit 9538146 into precision/verified-readiness-20261109 Nov 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant